Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe logs from the virtual interface to the extension through the whist tag #7196

Open
rebasedming opened this issue Sep 6, 2022 · 0 comments
Labels
devOps Improving or adding new tests & CI capabilities feature New feature or request priority-2-urgent #2 Priority - We need to fix this bug ASAP 📁 Repo: hybrid This PR/Issue modifies /hybrid code

Comments

@rebasedming
Copy link
Collaborator

rebasedming commented Sep 6, 2022

Feature Description
Currently protocol logs only exist in the virtual interface and it's really hard to send them to logz.io because we'd need to write our own http request in C++. I tried our old C http request function but it wasn't working, and also tried importing Chromium's http request functions but those are meant for use in the browser process and the virtual interface lives in the renderer process.

A much cleaner implementation is to

  1. Have the virtual interface pass each log to the whist element
  2. Add an event emitter to the whist element that emits logs
  3. Each log is tagged with a unique, incrementing ID
  4. All tags broadcast the logs to the extension
  5. The extension listens for the logs and uses the logz.io JS API to send the logs up to the server only if the ID is unique (since there can be multiple whist tags at once)
@rebasedming rebasedming added the priority-2-urgent #2 Priority - We need to fix this bug ASAP label Sep 6, 2022
@philippemnoel philippemnoel added feature New feature or request devOps Improving or adding new tests & CI capabilities 📁 Repo: hybrid This PR/Issue modifies /hybrid code labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devOps Improving or adding new tests & CI capabilities feature New feature or request priority-2-urgent #2 Priority - We need to fix this bug ASAP 📁 Repo: hybrid This PR/Issue modifies /hybrid code
Projects
None yet
Development

No branches or pull requests

2 participants