Infinite loop in randomInt

[miyaokamarina]

The randomInt() function loops infinitely under certain conditions, this is a serious DoS vulnerability.

The loop in randomInt() always uses the state value that never changes, so if a resulting value fails the threshold test only once, the loop will repeat forever.

It should rather be something like n = pcg.getOutput(nextPcg.state), so that the current state is used, not the initial one.

[miyaokamarina]

Some details on the probability of infinite loop: https://functor.network/user/790/entry/270#the-exploit

[philihp]

Thank for your thorough audit. I'll implement your suggestion, it does look like I made a mistake in not advancing state.

I am not so certain of a DoS vulnerability, but if you could provide an initState, streamID, and with which provided output function it exists that the second state is 0, I would love to add it as a test case.