Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded corners in dp and in wrong category #23

Open
mrgreywater opened this issue Mar 12, 2020 · 1 comment
Open

Rounded corners in dp and in wrong category #23

mrgreywater opened this issue Mar 12, 2020 · 1 comment

Comments

@mrgreywater
Copy link

mrgreywater commented Mar 12, 2020

The rounded corners setting is in the headphones category:

android:title="Set rounded corners diameter"

Also it seems to be in dp instead of physical px, therefore it needs to be adjusted depending on the dpi in the android settings.

If the settings where taken from the user as px, they could be converted to dp with something like

int dp = (int) Math.ceil(getResources().getDisplayMetrics().density * px);

according to https://stackoverflow.com/a/6656774

@phhusson
Copy link
Owner

Thanks. Would you mind doing a pull request for this?

AndyCGYan pushed a commit to AndyCGYan/treble_app that referenced this issue Nov 30, 2023
feat(nubia): add switch to enable/disable shoulder buttons/triggers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants