-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description/Voicing design pattern for Accordion Box #131
Comments
More context and details coming soon. |
I have made these suggestions in design behaviour. The behavior and design for Accordion Box for both Interactive Description and Voicing are outlined in the table headers in #131 (comment) For Trig Tour's Interactive Description this means:
For Trig Tour's Voicing this means:
|
@jessegreenberg , I think these patterns for Interactive Description and Voicing can be part of common code. |
After reviewing #131 (comment) it looks like the change request is
Is that summary correct and is that the desired pattern for all AccordionBoxes? Can you describe the reason for removing the help text? I ask because we recently added a feature to common code to make the default |
@jessegreenberg asked
Given point 3, if helpText is not needed for an interactive control in the Interactive Description feature, there should still be an option to provide a voicingHintRespone for that same control in the Voicing feature. This option would also allow for a voicingHintRespone to be different from the helpText - ideally option is to be avoided, but nice to have the flexibility. |
OK thanks @terracoda - during a meeting today we also talked about the following options to support this behavior:
|
…lapsed states, remove helpText, see #131
OK, the requested changes have been made to AccordionBox. @terracoda can you please review the behavior? |
I am reviewing the Interactive Description and Voicing designs for RaP's accordion box to help me with this description design pattern.
Interactive Description Design for RaP's My Challenge accordion box:
Voicing Design for RaP's My Challenge accordion box:
The text was updated successfully, but these errors were encountered: