-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scenery fill/stroke doesn't support TinyProperty #1612
Comments
…se isTReadOnlyProperty), phetsims/scenery#1612
…se isTReadOnlyProperty), phetsims/scenery#1612
…se isTReadOnlyProperty), phetsims/scenery#1612
…se isTReadOnlyProperty), phetsims/scenery#1612
For review:
@jonathanolson can you please review the above commits? Thanks. |
This issue mainly started because I thought that b8f7e12 would be a simple and easy change, but it actually opened up can of worms. I'm glad that I hit this instead of someone else since it seems so obvious that TReadOnlyProperty should behave the same when passing into scenery options. |
I'll test snapshot again on firefox, because that may be chromes fault (says @jonathanolson). |
The pixel comparisons on firefox showed no changes. Thanks for the tip @jonathanolson. |
…se isTReadOnlyProperty), phetsims/scenery#1612
I was surprised to see many spots with
instanceof ReadOnlyProperty
without any notion of TinyProperty. I'll take a look. I got bit for ~2 hours on this over in phetsims/buoyancy#96 thinking I had done something wrong in THREE.js when actually it was just that I was using aTinyProperty<Color>
instead of aProperty<Color>
.The text was updated successfully, but these errors were encountered: