You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In NumberPairsPreferencesNode.ts, the code below should be factored out into class NumberModelTypeControl extends PreferencesControl. That will make it easier to address the PhET-iO instrumentation of this component, which is currently lacking/incorrect -- the control itself currently has no tandem and no visibleProperty, and numberModelRadioButtonGroup should be a child of that control.
constnumberModelRadioButtonGroup=newRectangularRadioButtonGroup(NumberPairsConstants.NUMBER_MODEL_TYPE_PROPERTY,[{createNode: ()=>newText('Number Bond',PreferencesDialogConstants.CONTROL_LABEL_OPTIONS),value: 'numberBondModel',tandemName: 'numberBondModelRadioButton'},{createNode: ()=>newText('Bar Model',PreferencesDialogConstants.CONTROL_LABEL_OPTIONS),value: 'barModel',tandemName: 'barModelRadioButton'}],{orientation: 'horizontal',tandem: options.tandem.createTandem('numberModelRadioButtonGroup'),isDisposable: false,// Hide or show the entire row, not just the radio buttonphetioVisiblePropertyInstrumented: false});constnumberModelControl=newPreferencesControl({labelNode: newText('Number Model Type',PreferencesDialogConstants.CONTROL_LABEL_OPTIONS),controlNode: numberModelRadioButtonGroup});
This will also clean up NumberPairsPreferencesNode.ts, which is already becoming a little difficult to read due to lack of whitespace between unrelated chunks of code:
constnumberModelRadioButtonGroup=newRectangularRadioButtonGroup(NumberPairsConstants.NUMBER_MODEL_TYPE_PROPERTY,
...
});constnumberModelControl=newPreferencesControl({labelNode: newText('Number Model Type',PreferencesDialogConstants.CONTROL_LABEL_OPTIONS),controlNode: numberModelRadioButtonGroup});constsecondLanguageControl=newSecondLanguageControl(
...
});
The text was updated successfully, but these errors were encountered:
In NumberPairsPreferencesNode.ts, the code below should be factored out into
class NumberModelTypeControl extends PreferencesControl
. That will make it easier to address the PhET-iO instrumentation of this component, which is currently lacking/incorrect -- the control itself currently has no tandem and novisibleProperty
, andnumberModelRadioButtonGroup
should be a child of that control.This will also clean up NumberPairsPreferencesNode.ts, which is already becoming a little difficult to read due to lack of whitespace between unrelated chunks of code:
The text was updated successfully, but these errors were encountered: