-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User question: incorrect wavelength in Bohr model #14
Comments
@oliver-phet Did the user include some sort of screen-shot with this report? I can't reproduce the issue they are reporting. |
I was able to recreate this behavior. Need to check into why a n=6 to n=5 transition results in an emission of a photon at 780 nm rather than at 7460 nm. |
Un-deferring, since development on this sim has resumed. |
Note to self, for future investigation... de Broglie, Schrodinger, and Bohr all use the same transition wavelengths. The Java implementation lives in BohrModel.js, and has not been ported to TypeScript yet. The transition wavelengths are computed by this method: /**
* Gets the transition wavelengths for a specified state.
* @param state
* @return double[]
*/
public double[] getTransitionWavelengths( int state ) { I'm not sure why the photon wavelength would be correct for Bohr, but incorrect for de Broglie. Transition wavelengths used to label the light's wavelength slider are computed by this method: /**
* Gets the set of wavelengths that cause a state transition.
* When firing white light, the gun prefers to firing these wavelengths
* so that the probability of seeing a photon absorbed is higher.
*
* @param minWavelength
* @param maxWavelength
* @return double[]
*/
public static double[] getTransitionWavelengths( double minWavelength, double maxWavelength ) { |
I added this assertion to Spectrometer // To verify that legacy issue https://github.com/phetsims/models-of-the-hydrogen-atom/issues/14 is no longer a problem.
assert && assert( photonAbsorptionModel.getTransition( wavelength ), `invalid emission wavelength: ${wavelength}` ); So if any invalid transition wavelength is encountered, the sim will complain loudly and fail. I ran the Bohr model with white light and the Spectrometer accordion box open for ~10 minutes and saw no problems. I'll let CT run for a few cycles to confirm before closing. |
Since I'm still curious about how this occurred in the legacy (Java) version, I searched the Java code base for 780. I found nothing in the hydrogen-atom project (sim-specific code), but I did find this in common-code VisibleColor.java: public static final double MAX_WAVELENGTH = 780; ... and there are several uses of |
The text was updated successfully, but these errors were encountered: