Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio tree review #100

Open
8 tasks done
pixelzoom opened this issue Jan 21, 2025 · 5 comments
Open
8 tasks done

Studio tree review #100

pixelzoom opened this issue Jan 21, 2025 · 5 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 21, 2025

@DianaTavares @arouinfar @Nancy-Salpepi The Studio tree is ready for review.

While Schrodinger is not finished, all of the model and view elements related to Schrodinger are present in the tree, and I'm expecting no additional PhET-iO elements to be added. Beware (and apologies) that you are likely to encounter assertion failures related to invalid (n,l,m) transitions -- just reload Studio if that happens while reviewing.

Things to review:

  • Names of elements
  • Structure of the tree, grouping, etc.
  • Linked elements
  • Over- and under-instrumentation
  • phetioFeatured
  • phetioReadonly
  • phetioDocumentation
  • Dynamic layout behavior when visibleProperty is changed

Feel free to report issues and change requests here, or create new issues, as you prefer.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jan 23, 2025

For this item:

  • Dynamic layout behavior when visibleProperty is changed

Especially these elements that are at the top-level, under *Screen.view. The implemented behavior is in parentheses, happy to discuss changing that behavior if it seems appropriate/worthwhile.

  • legendPanel.visibleProperty (nothing moves)
  • lightControlPanel.visibleProperty (nothing moves)
  • spectrometerAccordionBox.visibleProperty (nothing moves)
  • electronEnergyLevelAccordionBox.visibleProperty (elements on the right will shift left)
  • continuumNode.visibleProperty (radio buttons move left)
  • experimentModelSwitch.visibleProperty (radio buttons move up)
  • atomicModelPanel.selfVisibleProperty (nothing moves)
  • timeControlNode.visibleProperty (nothing moves)

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jan 23, 2025

#102 resulted in some minor PhET-iO changes under continuumNode, so please do your review using main (via phettest).

@pixelzoom
Copy link
Contributor Author

In 1/27/25 design meeting with @DianaTavares @arouinfar @Nancy-Salpepi , we reviewed the remaining visibleProperty items in #100 (comment) and checked them off.

Is there anything else to do here?

@DianaTavares
Copy link
Contributor

I don't have anything to add related to PhET-iO or this issue

@arouinfar
Copy link

I'd like to sanity check the phetioFeatured elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants