Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to allow internal Tonel generated without files #55

Open
bencoman opened this issue Oct 21, 2018 · 4 comments
Open

Refactor to allow internal Tonel generated without files #55

bencoman opened this issue Oct 21, 2018 · 4 comments

Comments

@bencoman
Copy link

bencoman commented Oct 21, 2018

We are writing a GUI for Exercism.io to submit solutions directly from Pharo to their web server,
so we need to generate Tonel files as strings without touching the file system.
Refactor to facilitate this.
[EDIT: I forgot to mention, I'll submit a PR for this soon]

@jecisc
Copy link
Contributor

jecisc commented Oct 23, 2018

+1

I would also like it to display the code of the Spec Examples next to them in a tab.

@jecisc
Copy link
Contributor

jecisc commented Oct 23, 2018

@bencoman Do you want to export a full package or just a class?

I don't see how you'll do to export a full package without files since it needs to generate multiple files. (Note that you can do it without "real" files with a MemoryFileSystem).

If it's to export only a class, I'll propose a PR.

@jecisc
Copy link
Contributor

jecisc commented Oct 23, 2018

@bencoman Can you check if this fixes what you want?

#56

@bencoman
Copy link
Author

bencoman commented Nov 3, 2018

@samWson, @macta fyi...

I've copied this from the PR for a more permanent record.
@jecisc, For Exercism we want to export a whole package-tag i.e. under our 'Exercism' placeholder package we have one exercise per package-tag. Here is the Tonel changes that facilitated that.

If you add that to a fresh system it can be used like this...

packageTag := (RPackageOrganizer default packageNamed: 'AST-Core') classTagNamed: 'Nodes'.
tonelMap := TonelWriter new mappedSnapshot: packageTag snapshot.

Then tonelMap is iterated to send it across the network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants