From 10d450f4c0866e9058a06b9182feb1a954fe590a Mon Sep 17 00:00:00 2001 From: adri09070 <97704417+adri09070@users.noreply.github.com> Date: Fri, 28 Apr 2023 15:54:19 +0200 Subject: [PATCH 1/4] fixing createSubclassResponsibility with steps --- src/NewTools-Debugger/StDebugger.class.st | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/NewTools-Debugger/StDebugger.class.st b/src/NewTools-Debugger/StDebugger.class.st index 635173ffa..7ac001a64 100644 --- a/src/NewTools-Debugger/StDebugger.class.st +++ b/src/NewTools-Debugger/StDebugger.class.st @@ -91,6 +91,7 @@ Class { 'stackAndCodeContainer' ], #classVars : [ + 'ActivateDebuggerExtensions', 'ErrorRecursion', 'FastTDD' ], @@ -427,11 +428,13 @@ StDebugger >> createMissingMethodFor: aMessage in: aClass [ StDebugger >> createSubclassResponsibility [ | senderContext msg chosenClass | - senderContext := self interruptedContext sender. + senderContext := self signalingSubclassResponsabilityContext. msg := Message selector: senderContext selector arguments: senderContext arguments. - chosenClass := self requestClassFrom: senderContext receiver class to: senderContext methodClass. + chosenClass := self + requestClassFrom: senderContext receiver class + to: senderContext methodClass. chosenClass ifNil: [ ^ self ]. self debuggerActionModel implement: msg @@ -1127,6 +1130,16 @@ StDebugger >> showFullStack [ ] +{ #category : #accessing } +StDebugger >> signalingSubclassResponsabilityContext [ + + | signalingContext | + signalingContext := self interruptedContext. + [ signalingContext selector = #subclassResponsibility ] whileFalse: [ + signalingContext := signalingContext sender ]. + ^ signalingContext sender +] + { #category : #'accessing - variables' } StDebugger >> stack [ ^ self debuggerActionModel stack From 42fa47df66b213734f803393e322aa3581fa51f0 Mon Sep 17 00:00:00 2001 From: adri09070 <97704417+adri09070@users.noreply.github.com> Date: Fri, 4 Aug 2023 16:33:11 +0200 Subject: [PATCH 2/4] adding test for subclass responsibility with steps --- .../StDebuggerActionModelTest.class.st | 9 +++- .../StDebuggerCommandTest.class.st | 43 +++++++++++++++++++ .../StTestDebuggerProvider.class.st | 25 +++++++++++ 3 files changed, 75 insertions(+), 2 deletions(-) diff --git a/src/NewTools-Debugger-Tests/StDebuggerActionModelTest.class.st b/src/NewTools-Debugger-Tests/StDebuggerActionModelTest.class.st index 08535f6b5..d1cfe0650 100644 --- a/src/NewTools-Debugger-Tests/StDebuggerActionModelTest.class.st +++ b/src/NewTools-Debugger-Tests/StDebuggerActionModelTest.class.st @@ -6,8 +6,7 @@ Class { 'debugActionModel', 'debugger', 'result', - 'shouldFilterStack', - 'methodWithBlockContextOriginalSource' + 'shouldFilterStack' ], #category : #'NewTools-Debugger-Tests-Model' } @@ -501,6 +500,12 @@ StDebuggerActionModelTest >> testIsInterruptedContextSubclassResponsibilityExcep self assert: debugActionModel isInterruptedContextSubclassResponsibilityException ] +{ #category : #'tests - predicates' } +StDebuggerActionModelTest >> testIsInterruptedContextSubclassResponsibilityExceptionWithSteps [ + self changeSession: StTestDebuggerProvider new debuggerWithMissingSubclassResponsibilityContextWithSteps session. + self assert: debugActionModel isInterruptedContextSubclassResponsibilityException +] + { #category : #'tests - actions' } StDebuggerActionModelTest >> testPeelToFirstLike [ diff --git a/src/NewTools-Debugger-Tests/StDebuggerCommandTest.class.st b/src/NewTools-Debugger-Tests/StDebuggerCommandTest.class.st index 589c5f4ae..3ed4267e6 100644 --- a/src/NewTools-Debugger-Tests/StDebuggerCommandTest.class.st +++ b/src/NewTools-Debugger-Tests/StDebuggerCommandTest.class.st @@ -204,6 +204,49 @@ StDebuggerCommandTest >> testCommandsInMissingSubclassResponsibilityContext [ self assert: (StWhereIsCommand forContext: debugger) canBeExecuted. ] +{ #category : #tests } +StDebuggerCommandTest >> testCommandsInMissingSubclassResponsibilityContextWithSteps [ + + | debugger | + [ + debugger := debuggerProvider + debuggerWithMissingSubclassResponsibilityContextWithSteps. + self assert: debugger debuggerActionModel + isInterruptedContextSubclassResponsibilityException. + + "Executable commands relative to context" + self assert: + (StDefineSubclassResponsabilityCommand forContext: debugger) + canBeExecuted. + self assert: + (StDefineMissingEntityCommand forContext: debugger) canBeExecuted. + self assert: (StRestartCommand forContext: debugger) canBeExecuted. + self assert: + (StReturnValueCommand forContext: debugger) canBeExecuted. + + "Non-executable commands relative to context" + self deny: (StStepIntoCommand forContext: debugger) canBeExecuted. + self deny: (StStepOverCommand forContext: debugger) canBeExecuted. + self deny: (StStepThroughCommand forContext: debugger) canBeExecuted. + self deny: + (StRunToSelectionCommand forContext: debugger) canBeExecuted. + self deny: (StProceedCommand forContext: debugger) canBeExecuted. + self deny: (StDefineClassCommand forContext: debugger) canBeExecuted. + self deny: (StDefineMethodCommand forContext: debugger) canBeExecuted. + + "Executable commands, whatever the context" + self assert: + (StCopyStackToClipboardCommand forContext: debugger) canBeExecuted. + self assert: + (StFileOutMethodCommand forContext: debugger) canBeExecuted. + self assert: + (StPeelToFirstCommand forContext: debugger) canBeExecuted. + self assert: + (StShowFullStackCommand forContext: debugger) canBeExecuted. + self assert: (StWhereIsCommand forContext: debugger) canBeExecuted ] + ensure: [ debugger ifNotNil: [ debugger clear ] ] +] + { #category : #tests } StDebuggerCommandTest >> testCommandsInRunnableContext [ diff --git a/src/NewTools-Debugger-Tests/StTestDebuggerProvider.class.st b/src/NewTools-Debugger-Tests/StTestDebuggerProvider.class.st index 98d78b414..26fc6a36d 100644 --- a/src/NewTools-Debugger-Tests/StTestDebuggerProvider.class.st +++ b/src/NewTools-Debugger-Tests/StTestDebuggerProvider.class.st @@ -91,6 +91,31 @@ StTestDebuggerProvider >> debuggerWithMissingSubclassResponsibilityContext [ ^ self newDebugger ] ] +{ #category : #helpers } +StTestDebuggerProvider >> debuggerWithMissingSubclassResponsibilityContextWithSteps [ + + | ctx dbg | + ctx := [ + StDummyDebuggerPresenter new + unimplementedSubclassResponsibility ] asContext. + + self + sessionFor: ctx + exception: (OupsNullException fromSignallerContext: ctx). + dbg := self newDebugger. + dbg + application: dbg class currentApplication; + initialize. + "We reach the subclass responsability" + dbg + stepOver; + stepOver; + stepInto; + stepOver. + + ^ dbg +] + { #category : #helpers } StTestDebuggerProvider >> debuggerWithObjectHalting [ [ StDebuggerObjectForTests new haltingMethod ] From fc7be108cf34ebdf4fdf14324a4d7b61fc93a3cd Mon Sep 17 00:00:00 2001 From: adri09070 <97704417+adri09070@users.noreply.github.com> Date: Fri, 20 Oct 2023 09:35:14 +0200 Subject: [PATCH 3/4] fixing undeclared variable and deleting assertion on a debug command that has been deleted --- .../StDebuggerActionModelTest.class.st | 11 ++++++++--- .../StDebuggerCommandTest.class.st | 2 -- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/NewTools-Debugger-Tests/StDebuggerActionModelTest.class.st b/src/NewTools-Debugger-Tests/StDebuggerActionModelTest.class.st index 87861b88e..99a3f61cd 100644 --- a/src/NewTools-Debugger-Tests/StDebuggerActionModelTest.class.st +++ b/src/NewTools-Debugger-Tests/StDebuggerActionModelTest.class.st @@ -809,10 +809,15 @@ StDebuggerActionModelTest >> testIsInterruptedContextSubclassResponsibilityExcep { #category : 'tests - predicates' } StDebuggerActionModelTest >> testIsInterruptedContextSubclassResponsibilityExceptionWithSteps [ - self changeSession: StTestDebuggerProvider new debuggerWithMissingSubclassResponsibilityContextWithSteps session. - self changeSession: dummyActionModel session. + + | dummyActionModel | + dummyActionModel := StTestDebuggerProvider new + debuggerWithMissingSubclassResponsibilityContextWithSteps + debuggerActionModel. + self changeSession: dummyActionModel session. dummyActionModel clear. - self assert: debugActionModel isInterruptedContextSubclassResponsibilityException + self assert: + debugActionModel isInterruptedContextSubclassResponsibilityException ] { #category : 'tests - actions' } diff --git a/src/NewTools-Debugger-Tests/StDebuggerCommandTest.class.st b/src/NewTools-Debugger-Tests/StDebuggerCommandTest.class.st index 48d11547a..a28b95a5d 100644 --- a/src/NewTools-Debugger-Tests/StDebuggerCommandTest.class.st +++ b/src/NewTools-Debugger-Tests/StDebuggerCommandTest.class.st @@ -278,8 +278,6 @@ StDebuggerCommandTest >> testCommandsInMissingSubclassResponsibilityContextWithS (StFileOutMethodCommand forContext: debugger) canBeExecuted. self assert: (StPeelToFirstCommand forContext: debugger) canBeExecuted. - self assert: - (StShowFullStackCommand forContext: debugger) canBeExecuted. self assert: (StWhereIsCommand forContext: debugger) canBeExecuted ] ensure: [ debugger ifNotNil: [ debugger clear ] ] ] From 8e0ac7288787de871388dcec2d46224a7726ee29 Mon Sep 17 00:00:00 2001 From: CyrilFerlicot Date: Sat, 21 Oct 2023 01:38:05 +0200 Subject: [PATCH 4/4] Convert back to Tonel V3 format --- .../BaselineOfNewTools.class.st | 19 +- src/BaselineOfNewTools/package.st | 2 +- src/HelpCenter/HCBrowser.class.st | 23 +-- src/HelpCenter/HCCentralPlace.class.st | 33 ++-- src/HelpCenter/HCMenu.class.st | 35 ++-- src/HelpCenter/HCPharoWebSite.class.st | 17 +- src/HelpCenter/LabeledImagePresenter.class.st | 24 +-- src/HelpCenter/package.st | 2 +- .../StCatalogBrowser.class.st | 11 +- src/NewTools-Catalog/package.st | 2 +- .../ChangeSorterModel.class.st | 63 +++--- .../SpChangeSorterPresenter.class.st | 165 ++++++++-------- .../SpDualChangeSorterPresenter.class.st | 71 +++---- src/NewTools-ChangeSorter/package.st | 2 +- .../StCritiqueBrowserPresenterTest.class.st | 17 +- ...tiquePackageSelectorPresenterTest.class.st | 11 +- ...CritiqueRuleSelectorPresenterTest.class.st | 27 +-- .../StCritiqueToolbarPresenterTest.class.st | 13 +- .../StResetWindowPresenterTest.class.st | 15 +- src/NewTools-CodeCritiques-Tests/package.st | 2 +- .../StCriticPackageChooserPresenter.class.st | 21 +- .../StCriticRuleChooserPresenter.class.st | 15 +- .../StCriticWizardPresenter.class.st | 27 +-- .../StPackageChooserPresenter.class.st | 41 ++-- src/NewTools-CriticsBrowser/package.st | 2 +- .../Breakpoint.extension.st | 10 +- .../Object.extension.st | 6 +- .../StBreakpointInspectionItem.class.st | 34 ++-- .../StDebuggerBreakpointInspection.class.st | 18 +- .../StDummyTestClassWithHalts.class.st | 10 +- .../StHaltAndBreakpointControlTest.class.st | 20 +- .../StHaltAndBreakpointController.class.st | 46 ++--- ...StHaltAndBreakpointControllerTest.class.st | 42 ++-- ...tHaltBreakpointInspectionItemTest.class.st | 38 ++-- .../StHaltCache.class.st | 60 +++--- .../StHaltCacheChanged.class.st | 8 +- .../StHaltCacheTest.class.st | 34 ++-- .../StHaltInspectionItem.class.st | 50 ++--- .../StObjectBreakpointInspection.class.st | 56 +++--- .../StObjectBreakpointInspectionTest.class.st | 22 ++- .../StRemoveBreakpointCommand.class.st | 12 +- .../VariableBreakpoint.extension.st | 10 +- .../package.st | 2 +- .../DebugSession.extension.st | 8 +- .../Exception.extension.st | 6 +- .../MessageNotUnderstood.extension.st | 4 +- .../OupsNullException.extension.st | 4 +- .../RBProgramNode.extension.st | 6 +- .../SpCodeInteractionModel.extension.st | 4 +- .../SystemNavigation.extension.st | 4 +- src/NewTools-Debugger-Extensions/package.st | 2 +- .../FLDebuggerStackSerializerTest.class.st | 13 +- src/NewTools-Debugger-Fuel-Tests/package.st | 2 +- .../FLDebuggerStackMaterialization.class.st | 11 +- .../FLDebuggerStackSerializer.class.st | 27 +-- .../StDebugger.extension.st | 4 +- .../StFuelOutStackCommand.class.st | 19 +- src/NewTools-Debugger-Fuel/package.st | 2 +- .../DebugSessionDecoratorForTest.class.st | 19 +- .../DebugSessionStorageForTest.class.st | 19 +- .../DebuggerSelectionRecordUnit.class.st | 17 +- .../DebuggerSelectorDecoratorForTest.class.st | 21 +- .../DebuggerSelectorForTests.class.st | 25 +-- .../DebuggerSelectorTest.class.st | 27 +-- .../DummyDebuggerForTests.class.st | 13 +- ...erForTests_CannotOpenDebugSession.class.st | 13 +- .../DummyDebuggerForTests_RankZero.class.st | 13 +- ...erForTests_RejectAllDebugSessions.class.st | 13 +- ...istenerForDebugSessionStorageTest.class.st | 17 +- ...ntListenerForDebuggerSelectorTest.class.st | 13 +- .../package.st | 2 +- .../AbstractDebugger.extension.st | 8 +- ...ggerAClassThatIsNotADebuggerClass.class.st | 7 +- ...ssionCannotBeOpenedByThisDebugger.class.st | 7 +- .../DebugSessionStorage.class.st | 47 ++--- .../DebugSessionStorageUnit.class.st | 17 +- ...rListAndDebugSessionListPresenter.class.st | 63 +++--- .../DebuggerSelector.class.st | 41 ++-- .../GTBytecodeDebugger.extension.st | 18 +- .../GTDebuggerSmokeTest.extension.st | 4 +- .../GTGenericStackDebugger.extension.st | 14 +- .../GTMoldableDebugger.extension.st | 8 +- .../GTSUnitDebugger.extension.st | 18 +- .../InformDebugger.extension.st | 8 +- .../InvalidValueForStorageLimit.class.st | 7 +- .../MorphicUIManager.extension.st | 4 +- .../NoDebugger.extension.st | 8 +- .../TranscriptDebugger.extension.st | 8 +- src/NewTools-DebuggerSelector/package.st | 2 +- .../StDAPackageRelationGraphTest.class.st | 11 +- .../StDependencyAnalyserTest.class.st | 9 +- .../package.st | 2 +- .../DAPackageDependency.extension.st | 4 +- .../StDependencyAnalyser.class.st | 15 +- src/NewTools-DependencyAnalyser/package.st | 2 +- .../StExternalBrowserPresenter.class.st | 91 ++++----- ...StExternalChangesBrowserPresenter.class.st | 61 +++--- src/NewTools-ExternalBrowser/package.st | 2 +- .../StFBAbstractFilterTest.class.st | 34 ++-- .../StFBBitmapFilterTest.class.st | 12 +- .../StFBDirectoryFilterTest.class.st | 12 +- .../StFBExtensionsFilterTest.class.st | 10 +- .../StFBFileDialogTest.class.st | 34 ++-- .../StFBFileFilterTest.class.st | 20 +- .../StFBFileSystemResource.class.st | 18 +- .../StFBGIFFilterTest.class.st | 12 +- .../StFBJPEGFilterTest.class.st | 12 +- .../StFBNavigationSystemTest.class.st | 38 ++-- .../StFBNilFilterTest.class.st | 12 +- .../StFBOpenDirectoryDialogTest.class.st | 16 +- .../StFBOpenFileDialogTest.class.st | 16 +- .../StFBPNGFilterTest.class.st | 12 +- .../StFBTestCase.class.st | 18 +- .../StFBVisibleFilterTest.class.st | 12 +- .../StFBWindowPathPresenterTest.class.st | 14 +- .../StFBWindowsExtensionsTest.class.st | 12 +- src/NewTools-FileBrowser-Tests/package.st | 2 +- .../DateAndTime.extension.st | 4 +- .../FileReference.extension.st | 8 +- .../SpSelectEntity.extension.st | 4 +- .../StFBAbstractBookMark.class.st | 20 +- .../StFBAbstractColumn.class.st | 26 +-- .../StFBAbstractFilter.class.st | 36 ++-- .../StFBAbstractPreviewer.class.st | 18 +- .../StFBAddBookmarkCommand.class.st | 16 +- .../StFBAllFilter.class.st | 14 +- .../StFBBitmapFilter.class.st | 12 +- .../StFBBookmark.class.st | 52 ++--- .../StFBContentPreviewer.class.st | 14 +- .../StFBCreationDateColumn.class.st | 16 +- .../StFBCustomExtensionsFilter.class.st | 26 +-- .../StFBDirectoryFilter.class.st | 14 +- .../StFBExtensionsFilter.class.st | 30 +-- .../StFBFileDialogPresenter.class.st | 110 +++++------ .../StFBFileFilter.class.st | 22 ++- ...StFBFileNavigationSystemPresenter.class.st | 92 ++++----- .../StFBGIFFilter.class.st | 12 +- .../StFBGroupBookmark.class.st | 20 +- .../StFBIconColumn.class.st | 18 +- .../StFBInspectCommand.class.st | 14 +- .../StFBInspectPreviewer.class.st | 14 +- .../StFBJPEGFilter.class.st | 12 +- .../StFBJPGPreviewer.class.st | 12 +- .../StFBLastOpenDateColumn.class.st | 16 +- .../StFBModificationDateColumn.class.st | 16 +- .../StFBMorphicUIManager.class.st | 30 +-- .../StFBNameColumn.class.st | 16 +- .../StFBNewFolderCommand.class.st | 14 +- .../StFBNoteBookPreviewerPresenter.class.st | 32 ++-- .../StFBNullPreviewer.class.st | 14 +- .../StFBOpenDirectoryDialog.class.st | 20 +- .../StFBOpenFileDialog.class.st | 20 +- .../StFBOpenFileOrDirectoryDialog.class.st | 14 +- .../StFBPNGFilter.class.st | 12 +- .../StFBPNGPreviewer.class.st | 12 +- .../StFBPathPresenter.class.st | 22 ++- .../StFBRemoveBookmarkCommand.class.st | 14 +- .../StFBRightsColumn.class.st | 16 +- .../StFBSaveFileDialog.class.st | 22 ++- .../StFBSizeColumn.class.st | 16 +- .../StFBVisibleFilter.class.st | 14 +- .../StFBWindowPathPresenter.class.st | 26 +-- .../StInspector.extension.st | 4 +- src/NewTools-FileBrowser/package.st | 2 +- .../FBByClassesPagePresenterTest.class.st | 14 +- .../FBByFlagsPagePresenterTest.class.st | 18 +- .../FBByPackagesPagePresenterTest.class.st | 14 +- .../FBByScopePagePresenterTest.class.st | 16 +- .../FBClassMock.class.st | 14 +- .../FBFlagPresentationPresenterTest.class.st | 24 +-- .../FBFlagTest.class.st | 28 +-- .../FBLocationTest.class.st | 16 +- .../FBMock.class.st | 20 +- .../FBMockFlagsListItems.class.st | 16 +- .../FBMockUseToTestDoubleClickAction.class.st | 20 +- .../FBObjectFlagTest.class.st | 14 +- .../FBStringFlagTest.class.st | 14 +- .../FBSymbolFlagTest.class.st | 14 +- .../ManifestNewToolsFlagBrowserTests.class.st | 8 +- src/NewTools-FlagBrowser-Tests/package.st | 2 +- .../FBByClassesPagePresenter.class.st | 18 +- .../FBByFlagsPagePresenter.class.st | 30 +-- .../FBByPackagesPagePresenter.class.st | 18 +- .../FBByScopePagePresenter.class.st | 20 +- .../FBDescriptionPresenter.class.st | 18 +- src/NewTools-FlagBrowser/FBFlag.class.st | 48 ++--- .../FBFlagPresentationPresenter.class.st | 24 +-- src/NewTools-FlagBrowser/FBLocation.class.st | 38 ++-- .../FBObjectFlag.class.st | 16 +- .../FBPagePresenter.class.st | 18 +- .../FBStringFlag.class.st | 16 +- .../FBSymbolFlag.class.st | 16 +- src/NewTools-FlagBrowser/FlagBrowser.class.st | 18 +- .../ManifestNewToolsFlagBrowser.class.st | 8 +- src/NewTools-FlagBrowser/package.st | 2 +- .../FontChooserTest.class.st | 11 +- src/NewTools-FontChooser-Tests/package.st | 2 +- src/NewTools-FontChooser/FontChooser.class.st | 35 ++-- .../LogicalFontManager.extension.st | 4 +- .../PragmaSetting.extension.st | 4 +- .../RubTextEditor.extension.st | 4 +- .../StFontChooserPresenter.class.st | 53 +++--- .../StFontChooserPresenterTest.class.st | 21 +- .../StringMorph.extension.st | 4 +- src/NewTools-FontChooser/UITheme.extension.st | 4 +- src/NewTools-FontChooser/package.st | 2 +- .../FLFuelCommandLineHandler.class.st | 24 +-- src/NewTools-Fuel/FLMaterializer.extension.st | 8 +- src/NewTools-Fuel/Object.extension.st | 4 +- src/NewTools-Fuel/package.st | 2 +- src/NewTools-Gtk/StGtkDebugSession.class.st | 13 +- .../StGtkMorphicUIManager.class.st | 9 +- .../StPharoApplication.extension.st | 10 +- .../StPharoGtkConfiguration.class.st | 25 +-- .../StPharoGtkDarkConfiguration.class.st | 15 +- src/NewTools-Gtk/package.st | 2 +- .../SpHelpBrowserPresenter.class.st | 35 ++-- src/NewTools-HelpBrowser/package.st | 2 +- .../StInspectorBaseTest.class.st | 25 +-- .../StInspectorMockObject.class.st | 27 +-- .../StInspectorMockObjectSubclass.class.st | 9 +- .../StInspectorTest.class.st | 35 ++-- .../StObjectContextModelTest.class.st | 9 +- .../StObjectContextPresenterTest.class.st | 15 +- .../StObjectPrinterTest.class.st | 15 +- ...tObjectWithPrintDoesNotUnderstand.class.st | 13 +- .../StObjectWithPrintError.class.st | 9 +- .../StObjectWithPrintHalt.class.st | 9 +- src/NewTools-Inspector-Tests/package.st | 2 +- .../SpKeymapPresenter.class.st | 53 +++--- src/NewTools-KeymapBrowser/package.st | 2 +- .../StSpotterStyleContributor.class.st | 9 +- src/NewTools-Morphic-Spotter/package.st | 2 +- src/NewTools-Morphic/Morph.extension.st | 8 +- .../StPharoApplication.extension.st | 6 +- .../StPharoMorphicConfiguration.class.st | 23 +-- .../StPharoStyleContributor.class.st | 13 +- src/NewTools-Morphic/package.st | 2 +- .../Object.extension.st | 6 +- .../StBreakpointCommand.class.st | 13 +- .../StHaltOnCallCommand.class.st | 17 +- .../StHaltOnReadCommand.class.st | 15 +- .../StHaltOnStateAccessCommand.class.st | 15 +- .../StHaltOnWriteCommand.class.st | 15 +- .../StMetaBrowserPresenter.extension.st | 6 +- .../StObjectBreakpointInspection.extension.st | 8 +- .../StObjectInspectorPresenter.extension.st | 10 +- .../StRawInspectionPresenter.extension.st | 12 +- .../package.st | 2 +- .../StPlaygroundBaseTest.class.st | 29 +-- .../StPlaygroundInteractionModelTest.class.st | 15 +- .../StPlaygroundPagePresenterTest.class.st | 29 +-- ...laygroundPageSummaryPresenterTest.class.st | 17 +- .../StPlaygroundPageTest.class.st | 21 +- ...tPlaygroundPageTestMockedWaitable.class.st | 15 +- .../StPlaygroundPagesPresenterTest.class.st | 15 +- .../StPlaygroundTest.class.st | 21 +- src/NewTools-Playground-Tests/package.st | 2 +- .../StPharoApplication.extension.st | 8 +- src/NewTools-Playground/StPlayground.class.st | 10 +- .../StPlaygroundAdoptVersionCommand.class.st | 14 +- ...doptVersionOnNewPlaygroundCommand.class.st | 14 +- .../StPlaygroundBindingsCommand.class.st | 18 +- .../StPlaygroundBindingsPresenter.class.st | 74 +++---- .../StPlaygroundCommand.class.st | 12 +- .../StPlaygroundDoItCommand.class.st | 18 +- .../StPlaygroundInteractionModel.class.st | 32 ++-- .../StPlaygroundLoadPageCommand.class.st | 14 +- ...undLoadPageOnNewPlaygroundCommand.class.st | 14 +- .../StPlaygroundMenuExtensionCommand.class.st | 10 +- .../StPlaygroundPage.class.st | 56 +++--- .../StPlaygroundPagePresenter.class.st | 102 +++++----- .../StPlaygroundPageSummaryPresenter.class.st | 18 +- ...StPlaygroundPageVersionsPresenter.class.st | 32 ++-- .../StPlaygroundPagesCommand.class.st | 18 +- .../StPlaygroundPagesPresenter.class.st | 46 ++--- .../StPlaygroundPresenter.class.st | 52 ++--- .../StPlaygroundPublishCommand.class.st | 24 +-- .../StPlaygroundScriptPage.class.st | 12 +- ...PlaygroundToolbarExtensionCommand.class.st | 12 +- .../StPlaygroundVersionsCommand.class.st | 18 +- .../StRemoveAllBindingsCommand.class.st | 16 +- .../StRemoveBindingCommand.class.st | 16 +- .../StShowLineNumbersCommand.class.st | 22 ++- .../StToggleBindingCommand.class.st | 20 +- src/NewTools-Playground/package.st | 2 +- .../StProjectLoaderMicrodownRenderer.class.st | 11 +- .../package.st | 2 +- .../LoadableProject.class.st | 45 ++--- .../StProjectLoader.class.st | 39 ++-- .../StProjectLoaderNullRenderer.class.st | 11 +- .../StProjectLoaderRenderer.class.st | 15 +- src/NewTools-ProjectLoader/package.st | 2 +- .../RTPatternMatcherTest.class.st | 15 +- .../package.st | 2 +- .../StRewriterAbstractApplier.class.st | 16 +- .../StRewriterDemoRules.class.st | 34 ++-- .../StRewriterEnvironmentCreator.class.st | 12 +- .../StRewriterPatternMatcher.class.st | 14 +- .../StRewriterRBApplier.class.st | 16 +- .../StRewriterRenrakuApplier.class.st | 16 +- .../StRewriterRuleHolder.class.st | 40 ++-- src/NewTools-RewriterTools-Backend/package.st | 2 +- .../StRewriterAbstractToolTest.class.st | 20 +- ...iterExpressionFinderPresenterTest.class.st | 14 +- .../StRewriterMatchToolPresenter.extension.st | 16 +- .../StRewriterMatchToolPresenterTest.class.st | 34 ++-- ...erOccurrencesBrowserPresenterTest.class.st | 14 +- .../StRewriterReplaceWithPanelTest.class.st | 12 +- ...StRewriterRuleEditorPresenterTest.class.st | 18 +- ...StRewriterRuleLoaderPresenter.extension.st | 4 +- ...StRewriterRuleLoaderPresenterTest.class.st | 12 +- .../StRewriterRulesHelpPresenterTest.class.st | 16 +- ...erRulesTableSelectorPresenter.extension.st | 4 +- ...ewriterScopeSelectorPresenter.extension.st | 8 +- ...ewriterScopeSelectorPresenterTest.class.st | 20 +- .../StRewriterSearchForPanelTest.class.st | 12 +- src/NewTools-RewriterTools-Tests/package.st | 2 +- src/NewTools-RewriterTools/Array.extension.st | 4 +- ...riterApplyRuleOnAllClassesCommand.class.st | 16 +- ...ApplyRuleOnSelectedClassesCommand.class.st | 16 +- .../StRewriterCheatSheetPresenter.class.st | 16 +- ...RewriterExpressionFinderPresenter.class.st | 34 ++-- .../StRewriterHelpBrowserPresenter.class.st | 38 ++-- .../StRewriterMatchToolPresenter.class.st | 50 ++--- ...writerOccurrencesBrowserPresenter.class.st | 22 ++- ...writerOpenExpressionFinderCommand.class.st | 16 +- .../StRewriterOpenHelpBrowserCommand.class.st | 16 +- .../StRewriterOpenMatchToolCommand.class.st | 16 +- .../StRewriterOpenRuleEditorCommand.class.st | 16 +- .../StRewriterOpenRuleLoaderCommand.class.st | 16 +- ...RewriterReplaceWithPanelPresenter.class.st | 16 +- .../StRewriterRuleEditorPresenter.class.st | 46 ++--- .../StRewriterRuleLoaderPresenter.class.st | 30 +-- ...writerRulesTableSelectorPresenter.class.st | 26 +-- .../StRewriterScopeSelectorPresenter.class.st | 52 ++--- ...StRewriterSearchForPanelPresenter.class.st | 16 +- .../StRewriterToolsStyleContributor.class.st | 10 +- .../String.extension.st | 4 +- src/NewTools-RewriterTools/package.st | 2 +- .../StSimpleDirectoryWrapper.class.st | 9 +- .../StSimpleFileSystemItemWrapper.class.st | 53 +++--- .../StSimpleFileUtils.class.st | 23 +-- .../StSimpleFileWrapper.class.st | 13 +- .../StSimpleIconCache.class.st | 29 +-- .../StSimpleRootDirectoryWrapper.class.st | 9 +- .../StSimpleRootDriveWrapper.class.st | 17 +- .../StSimpleWin32Info.class.st | 13 +- .../package.st | 2 +- .../StSimpleFileBrowserPresenter.class.st | 76 ++++---- .../StSimpleFileDetailPresenter.class.st | 28 +-- .../StSimpleFolderContentPresenter.class.st | 28 +-- .../StSimpleFolderStructurePresenter.class.st | 26 +-- .../StSimplePathNamePresenter.class.st | 18 +- src/NewTools-SimpleFileBrowser-UI/package.st | 2 +- .../SindarinCommandsTest.class.st | 29 +-- .../SindarinTestCommandDebugger.class.st | 25 +-- .../SindarinTestObjectToVisit.class.st | 27 +-- .../SindarinTestVisitor.class.st | 19 +- .../package.st | 2 +- ...SindarinProcessInspectorPresenter.class.st | 19 +- .../package.st | 2 +- .../SindarinDebugger.extension.st | 10 +- .../StBytecodeInspectorSlotNode.class.st | 9 +- .../StDebugger.extension.st | 4 +- ...arinBytecodeContextInspectorModel.class.st | 15 +- ...SindarinBytecodeDebuggerPresenter.class.st | 31 +-- ...StSindarinContextInteractionModel.class.st | 15 +- .../StSindarinDebuggerPresenter.class.st | 21 +- ...indarinDebuggerScriptingPresenter.class.st | 37 ++-- src/NewTools-Sindarin-Tools/package.st | 2 +- .../RubUnderlinedSegmentMorph.extension.st | 4 +- .../SpAbstractTextPresenter.extension.st | 6 +- .../SpMorphicBaseTextAdapter.extension.st | 6 +- .../SpTextPresenterDecorator.class.st | 49 ++--- ...senterDecoratorMorphicAdapterTest.class.st | 15 +- .../SpTextPresenterDecoratorTest.class.st | 13 +- .../package.st | 2 +- .../AbstractFileReference.extension.st | 12 +- .../Behavior.extension.st | 18 +- .../Class.extension.st | 12 +- .../ClassDescription.extension.st | 4 +- .../Collection.extension.st | 4 +- .../CompiledMethod.extension.st | 16 +- .../Dictionary.extension.st | 4 +- .../GlobalVariable.extension.st | 8 +- .../KMDispatcher.extension.st | 4 +- .../MCPackage.extension.st | 6 +- .../MCVersionInfo.extension.st | 8 +- .../MCWorkingCopy.extension.st | 14 +- .../MenuItemMorph.extension.st | 6 +- .../MetacelloAbstractPackageSpec.extension.st | 6 +- .../MetacelloProject.extension.st | 4 +- .../MetacelloVersion.extension.st | 6 +- .../Morph.extension.st | 8 +- .../Pragma.extension.st | 10 +- .../RPackage.extension.st | 14 +- .../RPackageTag.extension.st | 4 +- .../ReflectiveMethod.extension.st | 12 +- .../SettingNode.extension.st | 6 +- .../SettingTree.extension.st | 4 +- .../StEntry.extension.st | 4 +- .../StFilterImplementor.class.st | 15 +- .../StSelector.class.st | 21 +- .../SystemWindow.extension.st | 6 +- src/NewTools-Spotter-Extensions/package.st | 2 +- .../StAbstractProcessorTest.class.st | 27 +-- .../StBenchProcessors.class.st | 23 +-- .../StCamelCaseSplitTest.class.st | 17 +- .../StClassProcessorTest.class.st | 19 +- .../StGeneratorBlockIteratorTest.class.st | 17 +- .../StGeneratorIteratorTest.class.st | 19 +- .../StHistoryProcessorTest.class.st | 19 +- .../StImplementorsProcessorTest.class.st | 17 +- .../StIteratorsTest.class.st | 63 +++--- .../StMockCandidatesList.class.st | 27 +-- .../StMockSpotterStream.class.st | 10 +- .../StPackageProcessorTest.class.st | 17 +- .../StUnifiedProcessorTest.class.st | 55 +++--- .../StWindowsProcessorTest.class.st | 23 +-- .../StWorldMenuProcessorTest.class.st | 25 +-- .../package.st | 2 +- ...ManifestNewToolsSpotterProcessors.class.st | 10 +- .../MenuItemMorph.extension.st | 4 +- .../MenuMorph.extension.st | 4 +- .../StAbstractStringFilter.class.st | 28 +-- .../StBeginsWithFilter.class.st | 12 +- .../StCaseSelectorIterator.class.st | 20 +- .../StClassEntry.class.st | 14 +- .../StClassIterator.class.st | 10 +- .../StClassProcessor.class.st | 18 +- .../StClassWithSelectorWordFilter.class.st | 12 +- .../StCollectionBasedProcessor.class.st | 16 +- .../StCollectionIterator.class.st | 16 +- .../StDefaultSourceFactory.class.st | 20 +- .../StEntry.class.st | 42 ++-- .../StFilter.class.st | 12 +- .../StGeneratorBlockIterator.class.st | 16 +- .../StGenericGenerator.class.st | 22 ++- .../StHistoryProcessor.class.st | 20 +- .../StImplementorsIterator.class.st | 10 +- .../StImplementorsProcessor.class.st | 18 +- .../StIterator.class.st | 40 ++-- .../StIteratorBlockDecorator.class.st | 14 +- .../StIteratorDecorator.class.st | 18 +- .../StMethodEntry.class.st | 16 +- .../StPackageEntry.class.st | 14 +- .../StPackageIterator.class.st | 10 +- .../StPackageProcessor.class.st | 18 +- .../StQuery.class.st | 34 ++-- .../StSendersIterator.class.st | 12 +- .../StSendersProcessor.class.st | 30 +-- .../StSequenceIterator.class.st | 18 +- .../StSourceFactory.class.st | 28 +-- .../StSpotterCandidatesListProcessor.class.st | 83 ++++---- .../StSpotterCandidatesProcessor.class.st | 39 ++-- .../StSpotterPragmaBasedProcessor.class.st | 59 +++--- .../StSpotterProcessor.class.st | 92 ++++----- .../StSubStringFilter.class.st | 12 +- .../StTransformation.class.st | 12 +- .../StUnifiedProcessor.class.st | 40 ++-- .../StWindowEntry.class.st | 14 +- .../StWindowsProcessor.class.st | 20 +- .../StWithoutDuplicatesDecorator.class.st | 18 +- .../StWordsAwareFilter.class.st | 16 +- .../StWorldMenuEntry.class.st | 18 +- .../StWorldMenuProcessor.class.st | 24 +-- .../String.extension.st | 4 +- src/NewTools-Spotter-Processors/package.st | 2 +- .../StSpotterBaseTest.class.st | 17 +- .../StSpotterModelTest.class.st | 11 +- .../StSpotterTest.class.st | 13 +- src/NewTools-Spotter-Tests/package.st | 2 +- .../BlockClosure.extension.st | 6 +- src/NewTools-Spotter/Class.extension.st | 4 +- .../CmdCommandActivator.extension.st | 4 +- .../DoubleLinkedList.extension.st | 8 +- src/NewTools-Spotter/Object.extension.st | 16 +- .../SequenceableCollection.extension.st | 4 +- src/NewTools-Spotter/StBaseFilter.class.st | 62 +++--- .../StClassEntry.extension.st | 6 +- src/NewTools-Spotter/StEntry.extension.st | 6 +- src/NewTools-Spotter/StFilterAlike.class.st | 24 +-- src/NewTools-Spotter/StFilterBlock.class.st | 14 +- src/NewTools-Spotter/StFilterFuzzy.class.st | 10 +- src/NewTools-Spotter/StFilterRegex.class.st | 18 +- .../StFilterStringMatch.class.st | 10 +- .../StFilterSubstring.class.st | 14 +- .../StFilterSubstrings.class.st | 18 +- src/NewTools-Spotter/StLimitArrived.class.st | 8 +- .../StMethodEntry.extension.st | 6 +- src/NewTools-Spotter/StNullFilter.class.st | 14 +- src/NewTools-Spotter/StOrderedFilter.class.st | 8 +- .../StPackageEntry.extension.st | 6 +- src/NewTools-Spotter/StSpotter.class.st | 180 +++++++++--------- .../StSpotterAllCandidatesAdded.class.st | 12 +- .../StSpotterAnnouncement.class.st | 12 +- .../StSpotterBasePresenter.class.st | 16 +- .../StSpotterBlockIterator.class.st | 14 +- .../StSpotterCandidateAdded.class.st | 14 +- .../StSpotterCandidateLink.class.st | 46 ++--- .../StSpotterCandidateLinkPresenter.class.st | 22 ++- .../StSpotterCandidatesAmountChanged.class.st | 12 +- .../StSpotterCandidatesList.class.st | 68 +++---- .../StSpotterContext.class.st | 98 +++++----- .../StSpotterHeaderPresenter.class.st | 58 +++--- .../StSpotterIterator.class.st | 94 ++++----- src/NewTools-Spotter/StSpotterModel.class.st | 84 ++++---- ...StSpotterPragmaBasedProcessor.extension.st | 4 +- .../StSpotterProcessor.extension.st | 10 +- .../StSpotterProcessorEnded.class.st | 14 +- .../StSpotterProcessorLink.class.st | 34 ++-- .../StSpotterProcessorStarted.class.st | 14 +- src/NewTools-Spotter/StSpotterQuery.class.st | 60 +++--- .../StSpotterQueryEnded.class.st | 8 +- .../StSpotterQueryStarted.class.st | 8 +- src/NewTools-Spotter/StSpotterStep.class.st | 52 ++--- src/NewTools-Spotter/StSpotterStream.class.st | 34 ++-- src/NewTools-Spotter/StStringFilter.class.st | 30 +-- .../StUnifiedProcessor.extension.st | 10 +- .../StUnorderedFilter.class.st | 12 +- src/NewTools-Spotter/String.extension.st | 4 +- .../ToolShortcutsCategory.extension.st | 4 +- src/NewTools-Spotter/package.st | 2 +- .../StSBBasePackageModel.class.st | 22 ++- .../StSBClassModel.class.st | 36 ++-- .../StSBClassesPanel.class.st | 24 +-- .../StSBEnvironmentModel.class.st | 20 +- .../StSBMethodModel.class.st | 24 +-- src/NewTools-SystemBrowser/StSBModel.class.st | 20 +- .../StSBPackageModel.class.st | 26 +-- .../StSBPackageTagModel.class.st | 26 +-- .../StSBPackagesPanel.class.st | 24 +-- src/NewTools-SystemBrowser/StSBPanel.class.st | 12 +- .../StSBProtocolInspectionPanel.class.st | 28 +-- .../StSBProtocolModel.class.st | 18 +- .../StSBVariableInspectionPanel.class.st | 28 +-- .../StSBVariableModel.class.st | 10 +- .../StSystemBrowser.class.st | 76 ++++---- src/NewTools-SystemBrowser/package.st | 2 +- .../StReporter.class.st | 10 +- .../StReporterPresenter.class.st | 34 ++-- .../StSizeReporter.class.st | 10 +- .../StSizeReporterPresenter.class.st | 54 +++--- .../StSystemReporter.class.st | 10 +- .../StSystemReporterPresenter.class.st | 56 +++--- src/NewTools-SystemReporter/package.st | 2 +- 547 files changed, 5647 insertions(+), 4977 deletions(-) diff --git a/src/BaselineOfNewTools/BaselineOfNewTools.class.st b/src/BaselineOfNewTools/BaselineOfNewTools.class.st index 2022b2576..7f4e0e6be 100644 --- a/src/BaselineOfNewTools/BaselineOfNewTools.class.st +++ b/src/BaselineOfNewTools/BaselineOfNewTools.class.st @@ -1,13 +1,14 @@ Class { - #name : #BaselineOfNewTools, - #superclass : #BaselineOf, + #name : 'BaselineOfNewTools', + #superclass : 'BaselineOf', #instVars : [ 'initializersEnabled' ], - #category : #BaselineOfNewTools + #category : 'BaselineOfNewTools', + #package : 'BaselineOfNewTools' } -{ #category : #baselines } +{ #category : 'baselines' } BaselineOfNewTools >> baseline: spec [ @@ -144,7 +145,7 @@ BaselineOfNewTools >> baseline: spec [ 'RewriterTools') ] ] -{ #category : #'external projects' } +{ #category : 'external projects' } BaselineOfNewTools >> chest: spec [ spec baseline: 'Chest' with: [ @@ -154,7 +155,7 @@ BaselineOfNewTools >> chest: spec [ loads: 'default' ] ] -{ #category : #'external projects' } +{ #category : 'external projects' } BaselineOfNewTools >> packageRepositoryURL [ | url | @@ -168,20 +169,20 @@ BaselineOfNewTools >> packageRepositoryURL [ ^ url ] -{ #category : #actions } +{ #category : 'actions' } BaselineOfNewTools >> postload: loader package: packageSpec [ MCMethodDefinition initializersEnabled: initializersEnabled ] -{ #category : #actions } +{ #category : 'actions' } BaselineOfNewTools >> preload: loader package: packageSpec [ initializersEnabled := MCMethodDefinition initializersEnabled. MCMethodDefinition initializersEnabled: true ] -{ #category : #'external projects' } +{ #category : 'external projects' } BaselineOfNewTools >> sindarin: spec [ spec baseline: 'Sindarin' with: [ diff --git a/src/BaselineOfNewTools/package.st b/src/BaselineOfNewTools/package.st index 0c639d564..5c6d87ebb 100644 --- a/src/BaselineOfNewTools/package.st +++ b/src/BaselineOfNewTools/package.st @@ -1 +1 @@ -Package { #name : #BaselineOfNewTools } +Package { #name : 'BaselineOfNewTools' } diff --git a/src/HelpCenter/HCBrowser.class.st b/src/HelpCenter/HCBrowser.class.st index ff210e595..7f6870d9c 100644 --- a/src/HelpCenter/HCBrowser.class.st +++ b/src/HelpCenter/HCBrowser.class.st @@ -1,14 +1,15 @@ Class { - #name : #HCBrowser, - #superclass : #ComposablePresenter, + #name : 'HCBrowser', + #superclass : 'ComposablePresenter', #instVars : [ 'listItems', 'docReader' ], - #category : #HelpCenter + #category : 'HelpCenter', + #package : 'HelpCenter' } -{ #category : #specs } +{ #category : 'specs' } HCBrowser class >> defaultSpec [ ^SpecRowLayout composed newColumn: [ :col | col add: #listItems ] origin: 0 @ 0 corner: 0.3 @ 1; @@ -17,38 +18,38 @@ HCBrowser class >> defaultSpec [ ] -{ #category : #accessing } +{ #category : 'accessing' } HCBrowser >> docReader [ ^ docReader ] -{ #category : #accessing } +{ #category : 'accessing' } HCBrowser >> docReader: anObject [ docReader := anObject ] -{ #category : #initialization } +{ #category : 'initialization' } HCBrowser >> initializePresenter [ ] -{ #category : #initialization } +{ #category : 'initialization' } HCBrowser >> initializeWidgets [ listItems := self newList. docReader := self newText. ] -{ #category : #accessing } +{ #category : 'accessing' } HCBrowser >> listItems [ ^ listItems ] -{ #category : #accessing } +{ #category : 'accessing' } HCBrowser >> listItems: anObject [ listItems := anObject ] -{ #category : #initialization } +{ #category : 'initialization' } HCBrowser >> title [ ^'HCBrowser' ] diff --git a/src/HelpCenter/HCCentralPlace.class.st b/src/HelpCenter/HCCentralPlace.class.st index 2fa5d5580..1d73ac139 100644 --- a/src/HelpCenter/HCCentralPlace.class.st +++ b/src/HelpCenter/HCCentralPlace.class.st @@ -1,15 +1,16 @@ Class { - #name : #HCCentralPlace, - #superclass : #ComposablePresenter, + #name : 'HCCentralPlace', + #superclass : 'ComposablePresenter', #instVars : [ 'menuComponent', 'hcbrowserComponent', 'hcPharoWebSiteComponent' ], - #category : #HelpCenter + #category : 'HelpCenter', + #package : 'HelpCenter' } -{ #category : #specs } +{ #category : 'specs' } HCCentralPlace class >> defaultSpec [ "menuComponent hcbrowserComponent" ^SpecColumnLayout composed @@ -21,7 +22,7 @@ HCCentralPlace class >> defaultSpec [ ] -{ #category : #'world menu' } +{ #category : 'world menu' } HCCentralPlace class >> menuCommandOn: aBuilder [ (aBuilder item: #'Help Center') @@ -33,62 +34,62 @@ HCCentralPlace class >> menuCommandOn: aBuilder [ withSeparatorAfter ] -{ #category : #specs } +{ #category : 'specs' } HCCentralPlace class >> open [