From 44ddc8bb0276c2d65640f9389ac3a42fda887502 Mon Sep 17 00:00:00 2001 From: adri09070 <97704417+adri09070@users.noreply.github.com> Date: Fri, 29 Sep 2023 14:25:14 +0200 Subject: [PATCH 1/3] removing unused shared variable in the debugger Co-authored-by: Steven Costiou <26929529+StevenCostiou@users.noreply.github.com> --- .../ArgumentVariable.extension.st | 4 +- .../CmAbstractCommandsGroup.extension.st | 4 +- .../CmCommandGroup.extension.st | 4 +- .../CmCommandGroupDecorator.extension.st | 4 +- src/NewTools-Debugger/Context.extension.st | 6 +- .../DebugSession.extension.st | 8 +- src/NewTools-Debugger/Object.extension.st | 6 +- .../SpCodePresenter.extension.st | 4 +- ...geAssertionFailureContextNotFound.class.st | 8 +- src/NewTools-Debugger/StDebugger.class.st | 326 +++++++++--------- .../StDebuggerActionModel.class.st | 158 ++++----- ...StDebuggerActionModelAnnouncement.class.st | 14 +- ...uggerActionModelClearAnnouncement.class.st | 8 +- ...onModelContextChangedAnnouncement.class.st | 8 +- ...ctionModelMethodAddedAnnouncement.class.st | 8 +- ...gerActionModelRestartAnnouncement.class.st | 8 +- ...ggerActionModelResumeAnnouncement.class.st | 8 +- ...buggerActionModelStepAnnouncement.class.st | 8 +- .../StDebuggerAssertionFailureResult.class.st | 16 +- .../StDebuggerCodeCommandTreeBuilder.class.st | 24 +- .../StDebuggerCommandTreeBuilder.class.st | 34 +- ...erConfigurationCommandTreeBuilder.class.st | 24 +- .../StDebuggerContext.class.st | 44 +-- ...StDebuggerContextInteractionModel.class.st | 38 +- .../StDebuggerContextPredicate.class.st | 44 +-- .../StDebuggerErrorContextPredicate.class.st | 28 +- ...DebuggerExtensionActivationToggle.class.st | 14 +- ...ensionInspectorNodeBuilderVisitor.class.st | 10 +- .../StDebuggerExtensionSettings.class.st | 12 +- .../StDebuggerExtensionVisitor.class.st | 22 +- .../StDebuggerInspector.class.st | 76 ++-- .../StDebuggerInspectorModel.class.st | 20 +- .../StDebuggerRawObjectInspector.class.st | 22 +- .../StDebuggerSpecSelector.class.st | 32 +- ...StDebuggerStackCommandTreeBuilder.class.st | 74 ++-- ...buggerTestFailureContextPredicate.class.st | 18 +- ...DebuggerToolbarCommandTreeBuilder.class.st | 46 +-- .../StDebuggerTreeTablePresenter.class.st | 20 +- .../StFailingAssertionInspector.class.st | 38 +- .../StRawInspectionPresenter.extension.st | 16 +- src/NewTools-Debugger/String.extension.st | 6 +- .../TStDebuggerExtension.trait.st | 30 +- .../TemporaryVariable.extension.st | 4 +- src/NewTools-Debugger/package.st | 2 +- 44 files changed, 685 insertions(+), 623 deletions(-) diff --git a/src/NewTools-Debugger/ArgumentVariable.extension.st b/src/NewTools-Debugger/ArgumentVariable.extension.st index 2423398fe..e07227899 100644 --- a/src/NewTools-Debugger/ArgumentVariable.extension.st +++ b/src/NewTools-Debugger/ArgumentVariable.extension.st @@ -1,6 +1,6 @@ -Extension { #name : #ArgumentVariable } +Extension { #name : 'ArgumentVariable' } -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } ArgumentVariable >> variableTag [ ^ 'arg' ] diff --git a/src/NewTools-Debugger/CmAbstractCommandsGroup.extension.st b/src/NewTools-Debugger/CmAbstractCommandsGroup.extension.st index 43ece7df3..ff458a978 100644 --- a/src/NewTools-Debugger/CmAbstractCommandsGroup.extension.st +++ b/src/NewTools-Debugger/CmAbstractCommandsGroup.extension.st @@ -1,6 +1,6 @@ -Extension { #name : #CmAbstractCommandsGroup } +Extension { #name : 'CmAbstractCommandsGroup' } -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } CmAbstractCommandsGroup >> commandOrGroupNamed: aString ifNone: aBlock [ self subclassResponsibility ] diff --git a/src/NewTools-Debugger/CmCommandGroup.extension.st b/src/NewTools-Debugger/CmCommandGroup.extension.st index b7cb6b0c6..cb8390bc6 100644 --- a/src/NewTools-Debugger/CmCommandGroup.extension.st +++ b/src/NewTools-Debugger/CmCommandGroup.extension.st @@ -1,6 +1,6 @@ -Extension { #name : #CmCommandGroup } +Extension { #name : 'CmCommandGroup' } -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } CmCommandGroup >> commandOrGroupNamed: aString ifNone: aBlock [ ^ entries detect: [ :commandOrRegister | commandOrRegister name = aString ] diff --git a/src/NewTools-Debugger/CmCommandGroupDecorator.extension.st b/src/NewTools-Debugger/CmCommandGroupDecorator.extension.st index d304ff7d0..0e78f1f00 100644 --- a/src/NewTools-Debugger/CmCommandGroupDecorator.extension.st +++ b/src/NewTools-Debugger/CmCommandGroupDecorator.extension.st @@ -1,6 +1,6 @@ -Extension { #name : #CmCommandGroupDecorator } +Extension { #name : 'CmCommandGroupDecorator' } -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } CmCommandGroupDecorator >> commandOrGroupNamed: aString ifNone: aBlock [ ^ self decoratedGroup commandOrGroupNamed: aString ifNone: aBlock ] diff --git a/src/NewTools-Debugger/Context.extension.st b/src/NewTools-Debugger/Context.extension.st index a27c0726c..f94b71a4b 100644 --- a/src/NewTools-Debugger/Context.extension.st +++ b/src/NewTools-Debugger/Context.extension.st @@ -1,6 +1,6 @@ -Extension { #name : #Context } +Extension { #name : 'Context' } -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } Context >> findFailedAssertionContextInSenderChain [ ^ (self findContextSuchThat: [ :ctx | @@ -9,7 +9,7 @@ Context >> findFailedAssertionContextInSenderChain [ StDebuggeAssertionFailureContextNotFound new signal ] ] -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } Context >> findFailedAssertionResultsInSenderChain [ |assertionContext assertionResult| assertionContext := self findFailedAssertionContextInSenderChain. diff --git a/src/NewTools-Debugger/DebugSession.extension.st b/src/NewTools-Debugger/DebugSession.extension.st index bab1242ad..12079682c 100644 --- a/src/NewTools-Debugger/DebugSession.extension.st +++ b/src/NewTools-Debugger/DebugSession.extension.st @@ -1,16 +1,16 @@ -Extension { #name : #DebugSession } +Extension { #name : 'DebugSession' } -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } DebugSession >> application [ ^ nil ] -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } DebugSession >> application: anApplication [ ] -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } DebugSession >> spanNewSession [ ^ (self class diff --git a/src/NewTools-Debugger/Object.extension.st b/src/NewTools-Debugger/Object.extension.st index 71a4f2392..054a05e6c 100644 --- a/src/NewTools-Debugger/Object.extension.st +++ b/src/NewTools-Debugger/Object.extension.st @@ -1,12 +1,12 @@ -Extension { #name : #Object } +Extension { #name : 'Object' } -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } Object >> presentDiffIn: aStFailingAssertionPresenter [ aStFailingAssertionPresenter initializeObjectDiffPresenters ] -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } Object >> presentDiffWith: anObject in: aStFailingAssertionPresenter [ aStFailingAssertionPresenter initializeObjectDiffPresenters diff --git a/src/NewTools-Debugger/SpCodePresenter.extension.st b/src/NewTools-Debugger/SpCodePresenter.extension.st index 999e35594..7268c4f28 100644 --- a/src/NewTools-Debugger/SpCodePresenter.extension.st +++ b/src/NewTools-Debugger/SpCodePresenter.extension.st @@ -1,6 +1,6 @@ -Extension { #name : #SpCodePresenter } +Extension { #name : 'SpCodePresenter' } -{ #category : #'*NewTools-Debugger' } +{ #category : '*NewTools-Debugger' } SpCodePresenter >> beForContext: aContext [ self interactionModel: (StDebuggerContextInteractionModel on: aContext) ] diff --git a/src/NewTools-Debugger/StDebuggeAssertionFailureContextNotFound.class.st b/src/NewTools-Debugger/StDebuggeAssertionFailureContextNotFound.class.st index 9513d79de..abfa6e7b6 100644 --- a/src/NewTools-Debugger/StDebuggeAssertionFailureContextNotFound.class.st +++ b/src/NewTools-Debugger/StDebuggeAssertionFailureContextNotFound.class.st @@ -2,7 +2,9 @@ I am raised when a context cannot find in its sender chain an assertion failure context, that is, a context that compared two value, an actual and an expected. " Class { - #name : #StDebuggeAssertionFailureContextNotFound, - #superclass : #Exception, - #category : #'NewTools-Debugger-Model' + #name : 'StDebuggeAssertionFailureContextNotFound', + #superclass : 'Exception', + #category : 'NewTools-Debugger-Model', + #package : 'NewTools-Debugger', + #tag : 'Model' } diff --git a/src/NewTools-Debugger/StDebugger.class.st b/src/NewTools-Debugger/StDebugger.class.st index 9c42851f0..c67e4399f 100644 --- a/src/NewTools-Debugger/StDebugger.class.st +++ b/src/NewTools-Debugger/StDebugger.class.st @@ -70,8 +70,8 @@ The meta inspection shows methods of the receiver's class hierarchy. Methods can be modified and saved in directly in that pane. " Class { - #name : #StDebugger, - #superclass : #StPresenter, + #name : 'StDebugger', + #superclass : 'StPresenter', #traits : 'TDebugger', #classTraits : 'TDebugger classTrait', #instVars : [ @@ -91,20 +91,21 @@ Class { ], #classVars : [ 'EnableStackColoring', - 'ErrorRecursion', 'FastTDD' ], - #category : #'NewTools-Debugger-View' + #category : 'NewTools-Debugger-View', + #package : 'NewTools-Debugger', + #tag : 'View' } -{ #category : #accessing } +{ #category : 'accessing' } StDebugger class >> activatedDebuggerExtensions [ ^ self extensionToolsClasses select: [ :extension | extension showInDebugger ] ] -{ #category : #commands } +{ #category : 'commands' } StDebugger class >> buildCommandsGroupWith: stDebuggerInstance forRoot: rootCommandGroup [ StDebuggerStackCommandTreeBuilder @@ -121,13 +122,13 @@ StDebugger class >> buildCommandsGroupWith: stDebuggerInstance forRoot: rootComm forRoot: rootCommandGroup ] -{ #category : #utilities } +{ #category : 'utilities' } StDebugger class >> closeAllDebuggers [