Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive_blfl - Address review comments #59

Open
rammprasad opened this issue Jun 19, 2024 · 2 comments · Fixed by #95
Open

derive_blfl - Address review comments #59

rammprasad opened this issue Jun 19, 2024 · 2 comments · Fixed by #95
Assignees

Comments

@rammprasad
Copy link
Collaborator

rammprasad commented Jun 19, 2024

          I have fixed a few minor items. Once this PR is approved, we can address the issues below.
  1. Refactor code based on suggestions - Last obs before exposure flag and baseline flag #49 (comment) and Last obs before exposure flag and baseline flag #49 (comment)
  2. Validate the ISO date formats.
  3. Add test case and example for baseline_visit functionality (Add test case for baseline_timepoints in derive_blfl function #95)
  4. Address code issues based on suggestion - Add test case for baseline_timepoints in derive_blfl function #95 (review)

Originally posted by @rammprasad in #49 (comment)

@rammprasad
Copy link
Collaborator Author

I see this as an enhancement to the derive_blfl function; it can be addressed in the V0.2. I will not decouple this from the V0l1 release.

@ramiromagno
Copy link
Collaborator

Nice! Then I think we have all tasks ticked in #65.

@ShiyuC ShiyuC linked a pull request Aug 29, 2024 that will close this issue
14 tasks
@ShiyuC ShiyuC reopened this Sep 12, 2024
@github-project-automation github-project-automation bot moved this from Product Backlog to Sprint Backlog in sdtm.oak R package Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint Backlog
Development

Successfully merging a pull request may close this issue.

4 participants