Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Use Full Title of referenced documents #463

Open
bms63 opened this issue Aug 27, 2024 · 0 comments
Open

Documentation: Use Full Title of referenced documents #463

bms63 opened this issue Aug 27, 2024 · 0 comments

Comments

@bms63
Copy link
Collaborator

bms63 commented Aug 27, 2024

          > > The FDA links go bad some times as they reorg their sites.

@zdz2101 and @millerg23 any ideas on what we were referencing there? I couldn't find anything sensible - https://www.fda.gov/science-research/liver-toxicity-knowledge-base-ltkb/drug-induced-liver-injury-severity-and-toxicity-dilist-dataset ??

I think the URL https://www.fda.gov/media/116737/download is correct. It is working for me when I open it in a browser. However, the workflow fails. I had the same issue with a similar URL in the last admiralonco release. I added the URL to .lycheeignore to avoid failure of our link check. CRAN didn't complain. I hope this no longer happens once we are using the CRAN link checker in our workflow.

oh good! it wasn't going to a Can't be Found page on the FDA website. @jimrothstein please add to the .lycheeignore so it doesn't check this one.

This failure did give me pause on thinking about documents that we link out. We should store a version on Phuse Teams Site so we go look it up even the document is no longer found on the web. I wasn't even sure on the title of this document to see if I could find it on the FDA site!

Originally posted by @bms63 in pharmaverse/admiral#2494 (comment)

Definition of Done

A simple note in writing vignettes that encourages the use of full tiles of documents and why we think this is a good idea! So we can find them when the links go bad!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant