You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the URL https://www.fda.gov/media/116737/download is correct. It is working for me when I open it in a browser. However, the workflow fails. I had the same issue with a similar URL in the last admiralonco release. I added the URL to .lycheeignore to avoid failure of our link check. CRAN didn't complain. I hope this no longer happens once we are using the CRAN link checker in our workflow.
oh good! it wasn't going to a Can't be Found page on the FDA website. @jimrothstein please add to the .lycheeignore so it doesn't check this one.
This failure did give me pause on thinking about documents that we link out. We should store a version on Phuse Teams Site so we go look it up even the document is no longer found on the web. I wasn't even sure on the title of this document to see if I could find it on the FDA site!
A simple note in writing vignettes that encourages the use of full tiles of documents and why we think this is a good idea! So we can find them when the links go bad!!
The text was updated successfully, but these errors were encountered:
oh good! it wasn't going to a Can't be Found page on the FDA website. @jimrothstein please add to the
.lycheeignore
so it doesn't check this one.This failure did give me pause on thinking about documents that we link out. We should store a version on Phuse Teams Site so we go look it up even the document is no longer found on the web. I wasn't even sure on the title of this document to see if I could find it on the FDA site!
Originally posted by @bms63 in pharmaverse/admiral#2494 (comment)
Definition of Done
A simple note in writing vignettes that encourages the use of full tiles of documents and why we think this is a good idea! So we can find them when the links go bad!!
The text was updated successfully, but these errors were encountered: