Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Issue: Remove quosures argument in vars2chr() #458

Closed
bundfussr opened this issue Jul 18, 2024 · 3 comments
Closed

General Issue: Remove quosures argument in vars2chr() #458

bundfussr opened this issue Jul 18, 2024 · 3 comments
Assignees
@ProfessorP-beep
Labels
programming

Comments

@bundfussr
Copy link
Collaborator

Background Information

The quosures argument in vars2chr() was deprecated in admiraldev 0.5.0. Thus it should be removed (or should have been removed in admiraldev 1.1.0).

Also check for other arguments or functions which should have been removed.

Definition of Done

No response
@ProfessorP-beep ProfessorP-beep self-assigned this Aug 4, 2024
@ProfessorP-beep
Copy link
Collaborator

I'll take a look this week.

@ProfessorP-beep
Copy link
Collaborator

Sorry, got caught up at work. Working on this now.

@ProfessorP-beep ProfessorP-beep linked a pull request Aug 18, 2024 that will close this issue
Removed the quosure argument from vars2chr(), get_source_vars()… #462
Closed
14 tasks
@bms63
Copy link
Collaborator

bms63 commented Aug 30, 2024

This got fixed in #464

@bms63 bms63 closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ProfessorP-beep ProfessorP-beep

Labels
programming
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed the quosure argument from vars2chr(), get_source_vars()… pharmaverse/admiraldev
3 participants
@bms63 @bundfussr @ProfessorP-beep