From 89db088977352e62a5e1468091e97ad4bd67518a Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Sat, 14 Dec 2024 15:25:50 -0800 Subject: [PATCH 1/5] # 2545 documentation - derive_basetype_records don't think I follow the logic; Thought: lawyers do it like this. i) criteria, AND exactly ONE of iia) criteria2, OR iib) criteria 2b blah blabh... --- R/derive_basetype_records.R | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/R/derive_basetype_records.R b/R/derive_basetype_records.R index dca942d651..521af38e2f 100644 --- a/R/derive_basetype_records.R +++ b/R/derive_basetype_records.R @@ -2,12 +2,12 @@ #' #' Baseline Type `BASETYPE` is needed when there is more than one definition of #' baseline for a given Analysis Parameter `PARAM` in the same dataset. For a -#' given parameter, if Baseline Value `BASE` is populated, and there is more than -#' one definition of baseline, then `BASETYPE` must be non-null on all records of -#' any type for that parameter. Each value of `BASETYPE` refers to a definition of -#' baseline that characterizes the value of `BASE` on that row. Please see -#' section 4.2.1.6 of the ADaM Implementation Guide, version 1.3 for further -#' background. +#' given parameter, if Baseline Value `BASE` or `BASEC` are non-null, and there +#' is more than one definition of baseline, then `BASETYPE` must be non-null on +#' all records of any type for that parameter. Each value of `BASETYPE` refers +#' to a definition of baseline that characterizes the value of `BASE` on that +#' row. Please see section 4.2.1.6 of the ADaM Implementation Guide, version +#' 1.3 for further background. #' #' Adds the `BASETYPE` variable to a dataset and duplicates records based upon #' the provided conditions. From e52872231ad7339f07e27421ab17699d679cc9e2 Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Sat, 14 Dec 2024 15:41:24 -0800 Subject: [PATCH 2/5] # 2545, 2604 fix typo line 233: ~~PARAMCAT1~~ PARCAT1 --- vignettes/bds_finding.Rmd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vignettes/bds_finding.Rmd b/vignettes/bds_finding.Rmd index 89255a017f..4233dd4bba 100644 --- a/vignettes/bds_finding.Rmd +++ b/vignettes/bds_finding.Rmd @@ -230,7 +230,7 @@ attr(param_lookup$VSTESTCD, "label") <- "Vital Signs Test Short Name" At this stage, only `PARAMCD` is required to perform the derivations. Additional derived parameters may be added, so only `PARAMCD` is joined to the datasets at -this point. All other variables related to `PARAMCD` (e.g. `PARAM`, `PARAMCAT1`, ...) +this point. All other variables related to `PARAMCD` (e.g. `PARAM`, `PARCAT1`, ...) will be added when all `PARAMCD` are derived. ```{r eval=TRUE} From 2e1f42573fd0820b683725c928dfb4e356547c27 Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Sat, 14 Dec 2024 15:57:07 -0800 Subject: [PATCH 3/5] #2545, #2604 fix typo, document() --- man/derive_basetype_records.Rd | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/man/derive_basetype_records.Rd b/man/derive_basetype_records.Rd index 19a9c07671..976fdb83a8 100644 --- a/man/derive_basetype_records.Rd +++ b/man/derive_basetype_records.Rd @@ -23,12 +23,12 @@ The input dataset with variable \code{BASETYPE} added \description{ Baseline Type \code{BASETYPE} is needed when there is more than one definition of baseline for a given Analysis Parameter \code{PARAM} in the same dataset. For a -given parameter, if Baseline Value \code{BASE} is populated, and there is more than -one definition of baseline, then \code{BASETYPE} must be non-null on all records of -any type for that parameter. Each value of \code{BASETYPE} refers to a definition of -baseline that characterizes the value of \code{BASE} on that row. Please see -section 4.2.1.6 of the ADaM Implementation Guide, version 1.3 for further -background. +given parameter, if Baseline Value \code{BASE} or \code{BASEC} are non-null, and there +is more than one definition of baseline, then \code{BASETYPE} must be non-null on +all records of any type for that parameter. Each value of \code{BASETYPE} refers +to a definition of baseline that characterizes the value of \code{BASE} on that +row. Please see section 4.2.1.6 of the ADaM Implementation Guide, version +1.3 for further background. } \details{ Adds the \code{BASETYPE} variable to a dataset and duplicates records based upon From dd4af9a37d762605b95cc8c142bf9786a57b7933 Mon Sep 17 00:00:00 2001 From: jim Date: Thu, 19 Dec 2024 07:48:36 -0800 Subject: [PATCH 4/5] Update R/derive_basetype_records.R Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com> --- R/derive_basetype_records.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/derive_basetype_records.R b/R/derive_basetype_records.R index 521af38e2f..b41fa90f60 100644 --- a/R/derive_basetype_records.R +++ b/R/derive_basetype_records.R @@ -2,7 +2,7 @@ #' #' Baseline Type `BASETYPE` is needed when there is more than one definition of #' baseline for a given Analysis Parameter `PARAM` in the same dataset. For a -#' given parameter, if Baseline Value `BASE` or `BASEC` are non-null, and there +#' given parameter, if Baseline Value `BASE` or `BASEC` are derived and there #' is more than one definition of baseline, then `BASETYPE` must be non-null on #' all records of any type for that parameter. Each value of `BASETYPE` refers #' to a definition of baseline that characterizes the value of `BASE` on that From 982d7f68dde5f93868b9010134d51a162c11efd8 Mon Sep 17 00:00:00 2001 From: Ben Straub Date: Sun, 22 Dec 2024 21:31:28 +0000 Subject: [PATCH 5/5] chore: #2545 docs --- man/derive_basetype_records.Rd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/derive_basetype_records.Rd b/man/derive_basetype_records.Rd index 976fdb83a8..680458a481 100644 --- a/man/derive_basetype_records.Rd +++ b/man/derive_basetype_records.Rd @@ -23,7 +23,7 @@ The input dataset with variable \code{BASETYPE} added \description{ Baseline Type \code{BASETYPE} is needed when there is more than one definition of baseline for a given Analysis Parameter \code{PARAM} in the same dataset. For a -given parameter, if Baseline Value \code{BASE} or \code{BASEC} are non-null, and there +given parameter, if Baseline Value \code{BASE} or \code{BASEC} are derived and there is more than one definition of baseline, then \code{BASETYPE} must be non-null on all records of any type for that parameter. Each value of \code{BASETYPE} refers to a definition of baseline that characterizes the value of \code{BASE} on that