Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WoW 9 - Shadowlands Issues #4

Open
stamicvs opened this issue Nov 28, 2020 · 7 comments
Open

WoW 9 - Shadowlands Issues #4

stamicvs opened this issue Nov 28, 2020 · 7 comments

Comments

@stamicvs
Copy link

Dear Phanx,

I am getting a lot of error messages with PhanxFont when I log in.
It would be great if you can make PhanxFont working in Shadowlands again.

Thank you very much in advance.
This is the error message:

`529x PhanxFont\Addon.lua:162: attempt to index field '?' (a nil value)
[string "@PhanxFont\Addon.lua"]:162: in function <PhanxFont\Addon.lua:150>

Locals:
self = PhanxFont {
0 =
}
event = "ADDON_LOADED"
addon = "PhanxFont"
(for index) = 1
(for limit) = 6
(for step) = 1
i = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = "1"
(*temporary) = "Text"
(*temporary) =
(*temporary) = nil
(*temporary) = ChatFrame1 {
GatherSelectedText = defined =[C]:-1
RefreshIfNecessary = defined =[C]:-1
OnPostShow = defined =[C]:-1
buttonSide = "left"
isInitialized = 1
GetNumVisibleLines = defined =[C]:-1
ScrollUp = defined =[C]:-1
SetTimeVisible = defined =[C]:-1
0 =
hasOwnFontObject = true
IsSelectingText = defined =[C]:-1
fadeDurationSecs = 3
GetJustifyV = defined =[C]:-1
CalculateLineAlphaValueFromTimestamp = defined =[C]:-1
GetFading = defined =[C]:-1
IsTextCopyable = defined =[C]:-1
Clear = defined =[C]:-1
shouldFadeAfterInactivity = true
channelList =

{
}
GetTimeVisible = defined =[C]:-1
MarkLayoutDirty = defined =[C]:-1
ScrollToBottom = defined =[C]:-1
GetInsertMode = defined =[C]:-1
GetMaxLines = defined =[C]:-1
oldAlpha = 0.156863
BackFillMessage = defined =[C]:-1
SetTextCopyable = defined =[C]:-1
UnpackageEntry = defined =[C]:-1
FontStringContainer = {
}
OnFontObjectUpdated = defined =[C]:-1
GetIndentedWordWrap = defined =[C]:-1
messageTypeList =
{
}
ScrollBar = {
}
GetFont = defined =[C]:-1
ResizeButton = ChatFrame1ResizeButton {
}
SetMaxLines = defined =[C]:-1
timeVisibleSecs = 120
OnPostUpdate = defined =[C]:-1
SetIndentedWordWrap = defined =[C]:-1
RefreshDisplay = defined =[C]:-1
SetFontObject = defined =[C]:-1
SetFont = defined =[C]:-1
textIsCopyable = false
onScrollChangedCallback = defined =[C]:-1
SetOnScrollChangedCallback = defined =[C]:-1
CalculateNumVisibleLines = defined =[C]:-1
isDocked = 1
fontObject = table: 00000226FA4FB660 {
}
overrideFadeTimestamp = 0
OnPostMouseDown = defined =[C]:-1
SetInsertMode = defined =[C]:-1
MarkDisplayDirty = defined =[C]:-1
SetShadowOffset = defined =[C]:-1
isLayoutDirty = true
CalculateSelectingCharacterIndicesForVisibleLine = defined =[C]:-1
GetMessageInfo = defined =[C]:-1
GetOnScrollChangedCallback = defined =[C]:-1
PackageEntry = defined =[C]:-1
UpdateSelectingText = defined =[C]:-1
AtTop = defined =[C]:-1
GetFontObject = defined =[C]:-1
zoneChannelList =
{
}
SetScrollOffset = defined =[C]:-1
isDisplayDirty = true
fontStringPool =
{
}
MakeFontObjectCustom = defined =[C]:-1
visibleLines =
{
}
CanEffectivelyFade = defined =[C]:-1
onDisplayRefreshedCallback = defined =[C]:-1
scrollOffset = 0
insertMode = 2
historyBuffer =
{
}
OnPreSizeChanged = defined =[C]:-1
Background = ChatFrame1Background {
}
GetScrollOffset = defined =[C]:-1
ResetSelectingText = defined =[C]:-1
ScrollDown = defined =[C]:-1
editBox = ChatFrame1EditBox {
}
ScrollToBottomButton = {
}
GetPagingScrollAmount = defined =[C]:-1
GetTextColor = defined =[C]:-1
SetJustifyV = defined =[C]:-1
CallOnDisplayRefreshed = defined =[C]:-1
AddMessage = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:100
GetScaledCursorPosition = defined =[C]:-1
GetSpacing = defined =[C]:-1
OnPreLoad = defined =[C]:-1
OnPostMouseUp = defined =[C]:-1
PageUp = defined =[C]:-1
SetSpacing = defined =[C]:-1
name = "General"
ScrollToTop = defined =[C]:-1
SetOnDisplayRefreshedCallback = <func`

@bubfeeld
Copy link

a friend of mine suggested this and it seems to mostly work:
PhanxFont should be easy enough to update to 9.0
[added]

\PhanxFont\Options.lua line 112
Fom:

local ScrollBG = CreateFrame("Frame", nil, self)

To:

local ScrollBG = CreateFrame("Frame", nil, self, BackdropTemplateMixin and "BackdropTemplate")

\PhanxFont\Libs\PhanxConfig-Dropdown\PhanxConfig-Dropdown.lua line 250
From:

local list = CreateFrame("Button", "PhanxConfigDropdown" .. id, dropdown)

To:

local list = CreateFrame("Button", "PhanxConfigDropdown" .. id, dropdown, BackdropTemplateMixin and "BackdropTemplate")

\PhanxFont\Libs\PhanxConfig-Slider\PhanxConfig-Slider.lua line 170
From:

local slider = CreateFrame("Slider", nil, frame)

To:

local slider = CreateFrame("Slider", nil, frame, BackdropTemplateMixin and "BackdropTemplate")

from https://us.forums.blizzard.com/en/wow/t/adjust-interface-font-size-not-ui-scale/707463

@stamicvs
Copy link
Author

Hi bubfeeld,

thank you very much for your reply.
I've adjusted the lines you suggested, unfortunately I still get a lot of error messages directly after loading the addon, so I guess there is something else beside the backdrop changes:
`1158x PhanxFont\Addon.lua:162: attempt to index field '?' (a nil value)
[string "@PhanxFont\Addon.lua"]:162: in function <PhanxFont\Addon.lua:150>

Locals:
self = PhanxFont {
0 =
}
event = "ADDON_LOADED"
addon = "PhanxFont"
(for index) = 1
(for limit) = 6
(for step) = 1
i = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = "1"
(*temporary) = "Text"
(*temporary) =
(*temporary) = nil
(*temporary) = ChatFrame1 {
GatherSelectedText = defined =[C]:-1
RefreshIfNecessary = defined =[C]:-1
OnPostShow = defined =[C]:-1
buttonSide = "left"
isInitialized = 1
GetNumVisibleLines = defined =[C]:-1
ScrollUp = defined =[C]:-1
SetTimeVisible = defined =[C]:-1
0 =
hasOwnFontObject = true
IsSelectingText = defined =[C]:-1
fadeDurationSecs = 3
GetJustifyV = defined =[C]:-1
CalculateLineAlphaValueFromTimestamp = defined =[C]:-1
GetFading = defined =[C]:-1
IsTextCopyable = defined =[C]:-1
Clear = defined =[C]:-1
shouldFadeAfterInactivity = true
channelList =

{
}
GetTimeVisible = defined =[C]:-1
MarkLayoutDirty = defined =[C]:-1
ScrollToBottom = defined =[C]:-1
GetInsertMode = defined =[C]:-1
GetMaxLines = defined =[C]:-1
oldAlpha = 0.156863
BackFillMessage = defined =[C]:-1
SetTextCopyable = defined =[C]:-1
UnpackageEntry = defined =[C]:-1
FontStringContainer = {
}
OnFontObjectUpdated = defined =[C]:-1
GetIndentedWordWrap = defined =[C]:-1
messageTypeList =
{
}
ScrollBar = {
}
GetFont = defined =[C]:-1
ResizeButton = ChatFrame1ResizeButton {
}
SetMaxLines = defined =[C]:-1
timeVisibleSecs = 120
OnPostUpdate = defined =[C]:-1
SetIndentedWordWrap = defined =[C]:-1
RefreshDisplay = defined =[C]:-1
SetFontObject = defined =[C]:-1
SetFont = defined =[C]:-1
textIsCopyable = false
onScrollChangedCallback = defined =[C]:-1
SetOnScrollChangedCallback = defined =[C]:-1
CalculateNumVisibleLines = defined =[C]:-1
isDocked = 1
fontObject = table: 00000226FA4FB660 {
}
overrideFadeTimestamp = 0
OnPostMouseDown = defined =[C]:-1
SetInsertMode = defined =[C]:-1
MarkDisplayDirty = defined =[C]:-1
SetShadowOffset = defined =[C]:-1
isLayoutDirty = true
CalculateSelectingCharacterIndicesForVisibleLine = defined =[C]:-1
GetMessageInfo = defined =[C]:-1
GetOnScrollChangedCallback = defined =[C]:-1
PackageEntry = defined =[C]:-1
UpdateSelectingText = defined =[C]:-1
AtTop = defined =[C]:-1
GetFontObject = defined =[C]:-1
zoneChannelList =
{
}
SetScrollOffset = defined =[C]:-1
isDisplayDirty = true
fontStringPool =
{
}
MakeFontObjectCustom = defined =[C]:-1
visibleLines =
{
}
CanEffectivelyFade = defined =[C]:-1
onDisplayRefreshedCallback = defined =[C]:-1
scrollOffset = 0
insertMode = 2
historyBuffer =
{
}
OnPreSizeChanged = defined =[C]:-1
Background = ChatFrame1Background {
}
GetScrollOffset = defined =[C]:-1
ResetSelectingText = defined =[C]:-1
ScrollDown = defined =[C]:-1
editBox = ChatFrame1EditBox {
}
ScrollToBottomButton = {
}
GetPagingScrollAmount = defined =[C]:-1
GetTextColor = defined =[C]:-1
SetJustifyV = defined =[C]:-1
CallOnDisplayRefreshed = defined =[C]:-1
AddMessage = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:100
GetScaledCursorPosition = defined =[C]:-1
GetSpacing = defined =[C]:-1
OnPreLoad = defined =[C]:-1
OnPostMouseUp = defined =[C]:-1
PageUp = defined =[C]:-1
SetSpacing = defined =[C]:-1
name = "General"
ScrollToTop = defined =[C]:-1
SetOnDisplayRefreshedCallback = <func`

@stamicvs
Copy link
Author

I now commented out line 161 until line 163 in the Addon.lua (Fix for Help Frame category buttons) and I am not receiving any error message at loading.

@bubfeeld
Copy link

bubfeeld commented Dec 1, 2020

good to know, i just turned off error messages since those changes seemed to make the fonts do what i wanted, bummed that i cannot adjust anything other than the scale under options though.

@Noobydoobie
Copy link

Hello. I was wondering whether there was ever an update to fix this? I am very grateful for this addon which I have just discovered.
I've tried Fontain, Fonter and Fontifier which now no longer work at all. I really only wanted to be able to change to a clearer font and enlarge it a little. This works great except for the error and the above solution looks a little complicated. Thank you in advance for any assistance you can provide.
My error looks like this:

40x PhanxFont\Addon.lua:162: attempt to index field '?' (a nil value)
[string "@PhanxFont\Addon.lua"]:162: in function <PhanxFont\Addon.lua:150>

@bubfeeld
Copy link

bubfeeld commented Feb 3, 2021

doing what the guy above me suggested will take away the error message, it is pretty simple, comment out line 161 until line 163 in the Addon.lua (Fix for Help Frame category buttons) and I am not receiving any error message at loading.
\PhanxFont\Addon.lua is the directory it should be found in

@Jixun-web
Copy link

I just want to thank you all for this and its fixes/updates.

I have had an issue with font sizing for a while and was dying to get something that this addon does for ages. I managed to follow the instructions given (not bad for an old man :P) and repaired it so i don't get any errors at all,.. and guys i love it!! it changes the worst part of my game to one of the best no more squinting and leaning into the screen so i can read everything comfortably.

Thank you all so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants