Incompatible with Go 1.23, which doesn't allow //go:linkname to internal symbols, including to runtime package

[stefanb]

While testing Go 1.23 rc1 in

• go 1.23, [email protected] 1.22.6 (new formula) Homebrew/homebrew-core#175310

there was an error:

go install -ldflags '-X github.com/pulumi/pulumi/pkg/v3/version.Version=v3.120.0' github.com/pulumi/pulumi/pkg/v3/cmd/pulumi
# github.com/pulumi/pulumi/pkg/v3/cmd/pulumi
link: github.com/pgavlin/text/internal/bytealg: invalid reference to internal/bytealg.MaxLen

Go 1.23 no longer allows //go:linkname * runtime.* link instructioins, see

• https://tip.golang.org/doc/go1.23#linker
• cmd/link: lock down future uses of linkname golang/go#67401

It is used several times in this module, see:

https://github.com/search?q=repo%3Apgavlin%2Ftext%20linkname&type=code

[pgavlin]

Well, this is unfortunate. Thanks for pointing this out. I'll have to look into what to do here.

[pgavlin]

Yeah this is going to take some work to fix.

The only feasible option I see is to vendor in the contents of internal/bytealg from the runtime. That will require some edits to the assembly versions of some functions, as they all use the runtime-internal ABI, which is disallowed outside of the runtime.

As a short-term workaround, this package can be used with go1.23 by adding -checklinkname=0 to -ldflags when building.

[pgavlin]

Fixed by b51d099.