Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --provided: like --exclude, but require the excluded project is available at boot time. #2426

Open
jsirois opened this issue Jun 10, 2024 · 0 comments

Comments

@jsirois
Copy link
Member

jsirois commented Jun 10, 2024

The --exclude feature is a very sharp tool. It requires you know to arrange the excluded project is made available to the PEX at runtime through --inherit-path / PEX_INHERIT_PATH or PEX_EXTRA_SYS_PATH in the case where the exclusion was configured to save size / bandwidth when the PEX is being deployed to an environment with pre-installed appropriate projects (the huge ML wheel case).

Ideally, Pex would support --provided and instead of discovering a missing --excluded project some time after PEX boot when the import finally triggers (this could be an arbitrary time in the future for dynamic plugin systems or in code with lazy imports in infrequently used code paths.

This idea was originally described here: #2097 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant