LOS 19.1 extendrom builds fail due to --enforce-uses-libraries

[petefoth]

Mon 22 Aug 22

I got the error below when building extendrom targets (repeated for most of the prebuilt targets)

The interesting bit is

- to temporarily disable the check for the whole product, set PRODUCT_BROKEN_VERIFY_USES_LIBRARIES := true in the product makefiles
- to fix the check, make build system properties coherent with the manifest
- see build/make/Changes.md for details

build/make/Changes.md says

* Android.bp property: `provides_uses_lib`
* Android.mk variable: `LOCAL_PROVIDES_USES_LIBRARY`

It is possible to disable the check on a per-module basis. When doing that it is
also recommended to disable dexpreopt, as disabling a failed check will result
in incorrect class loader context recorded in the .odex file, which will cause
class loader context mismatch and dexopt at first boot.

* Android.bp property: `enforce_uses_lib`
* Android.mk variable: `LOCAL_ENFORCE_USES_LIBRARIES`

I "fixed" my build by calling export RELAX_USES_LIBRARY_CHECK=true, then mka bacon. A better "fix" is by changing /tools/extract_utils.sh to add the line LOCAL_ENFORCE_USES_LIBRARIES := false to each module in Android.mk

I can try this in my extendrom fork , and submit the patches upstream

[petefoth]

Here's the full error text

 66% 93070/139054] Verifying uses-libraries: vendor/extendrom/prebuilt/at.bitfire.davdroid_LATEST.apk
FAILED: out/target/common/obj/APPS/DAVx5_intermediates/enforce_uses_libraries.status
/bin/bash -c "(rm -f out/target/common/obj/APPS/DAVx5_intermediates/enforce_uses_libraries.status ) && (build/soong/scripts/manifest_check.py 	  --enforce-uses-libraries 	  --enforce-uses-libraries-status out/target/common/obj/APPS/DAVx5_intermediates/enforce_uses_libraries.status 	  --aapt out/host/linux-x86/bin/aapt 	   	   	   	   	  vendor/extendrom/prebuilt/at.bitfire.davdroid_LATEST.apk )"
error: mismatch in the <uses-library> tags between the build system and the manifest:
	- required libraries in build system: []
	                 vs. in the manifest: []
	- optional libraries in build system: []
	                 vs. in the manifest: [androidx.window.extensions, androidx.window.sidecar]
	- tags in the manifest (vendor/extendrom/prebuilt/at.bitfire.davdroid_LATEST.apk):
		uses-library-not-required:'androidx.window.extensions'		uses-library-not-required:'androidx.window.sidecar'
note: the following options are available:
	- to temporarily disable the check on command line, rebuild with RELAX_USES_LIBRARY_CHECK=true (this will set compiler filter "verify" and disable AOT-compilation in dexpreopt)
	- to temporarily disable the check for the whole product, set PRODUCT_BROKEN_VERIFY_USES_LIBRARIES := true in the product makefiles
	- to fix the check, make build system properties coherent with the manifest
	- see build/make/Changes.md for details

22:55:00 ninja failed with: exit status 1

#### failed to build some targets (01:08:45 (hh:mm:ss)) ####