Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit 1, lesson 5. Inconsistency between text and the code. #241

Open
snekbaev opened this issue Aug 31, 2017 · 3 comments
Open

Unit 1, lesson 5. Inconsistency between text and the code. #241

snekbaev opened this issue Aug 31, 2017 · 3 comments

Comments

@snekbaev
Copy link

Hi,

Docs say:

This one is a little counter-intuitive. Here's the deal.
In this case, we aren't using the handle for consoleWriterActor to talk directly to it. Instead we are putting that IActorRef inside a message that is getting sent somewhere else in the system for processing. When that message is received, the receiving actor will know everything it needs to in order to do its job.

yet FileValidatorActor is using the _consoleWriterActor directly in several places.

Thank you!

@skataben
Copy link

I noticed this too. It is not as decoupled as the lesson implies.

@Aaronontheweb
Copy link
Member

I'll need to take a look at the language there - I didn't write that section of unit 1 :p

@skataben
Copy link

Cool no worries. Still working my way through these lessons which are great btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants