Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modify error logs acording to x/liquidstakeibc module #814

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

Ehsan-saradar
Copy link
Contributor

1. Overview

This PR only tries to clean x/liquidstake module loggings, so there's no changes to the consensus.

2. Implementation details

  • Added some consts for log key-values in the types directory.
  • Better messages for error logs

3. How to test/use

Doesn't need any testing

4. Checklist

  • Investigate to see if we benefit adding more loggings to this module.
  • Does the Readme need to be updated?

@Ehsan-saradar Ehsan-saradar requested a review from a team as a code owner April 17, 2024 08:44
Copy link

@Ehsan-saradar your pull request is missing a changelog!

Copy link
Collaborator

@kruspy kruspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of it is fine but I am still missing some additional error logs in other places.

Not sure if you are preparing another PR for it.

x/liquidstake/keeper/liquidstake.go Show resolved Hide resolved
x/liquidstake/keeper/rebalancing.go Show resolved Hide resolved
@Ehsan-saradar Ehsan-saradar changed the title Modify error logs acording to x/liquidstakeibc module chore: Modify error logs acording to x/liquidstakeibc module Apr 18, 2024
@kruspy kruspy merged commit d8e3202 into main Apr 23, 2024
8 of 9 checks passed
@kruspy kruspy deleted the chore/better-logs-for-liquidstake-module branch April 23, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants