Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude recently changed lines #582

Closed
erkekin opened this issue Feb 27, 2023 · 2 comments
Closed

Exclude recently changed lines #582

erkekin opened this issue Feb 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@erkekin
Copy link

erkekin commented Feb 27, 2023

In my team we don't want to use //periphery: ignore given we believe we will forget removing comments in the future. That's why we came to agree that periphery may provide an API to exclude outputting lines which has recently changed.

in order to ignore the lines which has been modified in the last week, we can call

periphery scan --exclude-lines-modified-before 7

so that teams which don't want to use comments in their code can benefit from the API.

@ileitch ileitch added the enhancement New feature or request label Feb 27, 2023
@ileitch
Copy link
Contributor

ileitch commented Mar 4, 2023

Ideally, this would be solved by detecting superfluous ignore comments (#427). To that end, I don't think this is something I will implement, as it ties Periphery to a particular SCM (git, I assume).

With a little script, you should be able to implement this quite easily yourself by post-processing the results.

@ileitch ileitch closed this as completed Mar 4, 2023
@erkekin
Copy link
Author

erkekin commented Mar 5, 2023

nice, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants