Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(8.0) PS-9453: percona_telemetry causes a long wait on COND_thd_list due to the absence of the root user #5460

Merged

Conversation

kamil-holubicki
Copy link
Contributor

@kamil-holubicki kamil-holubicki commented Oct 23, 2024

https://perconadev.atlassian.net/browse/PS-9453

Post push fix.

During the installation of Percona Telemetry Component we grant
'mysql.session' user with additional privileges.
It happens during the server startup, so servers started during the test
will have related timestamps different in general.
Some tests (e.g. clone plugin related) restore the clone instance state
by cloning the donor. In such a case restored instance will have
different timestamps at the beginning and the end of the test and MTR
check will complain because of different tables checksums.

Workaround this problem by excluding mysql.tables_priv from checksum
calculation. Instead, dump all tables privileges but without TIMESTAMP
column.

This is the same approach as for INFORMATION_SCHEMA.ROUTINES.

@kamil-holubicki kamil-holubicki changed the title PS-9453: percona_telemetry causes a long wait on COND_thd_list due to the absence of the root user (8.0) PS-9453: percona_telemetry causes a long wait on COND_thd_list due to the absence of the root user Oct 23, 2024
… the absence of the root user

https://perconadev.atlassian.net/browse/PS-9453

Post push fix.

During the installation of Percona Telemetry Component we grant
'mysql.session' user with additional privileges.
It happens during the server startup, so servers started during the test
will have related timestamps different in general.
Some tests (e.g. clone plugin related) restore the clone instance state
by cloning the donor. In such a case restored instance will have
different timestamps at the beginning and the end of the test and MTR
check will complain because of different tables checksums.

Workaround this problem by excluding mysql.tables_priv from checksum
calculation. Instead, dump all tables privileges but without TIMESTAMP
column.

This is the same approach as for INFORMATION_SCHEMA.ROUTINES.
@kamil-holubicki kamil-holubicki force-pushed the PS-9453-post-push-fix-8.0 branch from 501d543 to 9078f2d Compare October 23, 2024 18:00
Copy link
Contributor

@dlenev dlenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kamil-holubicki kamil-holubicki merged commit 3223244 into percona:8.0 Oct 24, 2024
8 of 9 checks passed
inikep added a commit that referenced this pull request Oct 25, 2024
…ercona/8.0) Merge pull request #5460 from kamil-holubicki/PS-9453-post-push-fix-8.0#
inikep added a commit to inikep/percona-server that referenced this pull request Oct 28, 2024
…ercona/8.0) Merge pull request percona#5460 from kamil-holubicki/PS-9453-post-push-fix-8.0#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants