-
Notifications
You must be signed in to change notification settings - Fork 5
EVEREST-107: config and secrets consistency via owner references #303
base: main
Are you sure you want to change the base?
Conversation
I like the idea of using the status field to help us manage what is currently an inconsistent state and I think we can leverage this to achieve the data consistency we're looking for. |
}) | ||
} | ||
|
||
bs.Status.Status = "Ready" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have the possible statuses defined as constants in one place
BucketName: bs.Spec.Bucket, | ||
Region: bs.Spec.Region, | ||
Url: &bs.Spec.EndpointURL, | ||
Status: bs.Status.Status, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to expose the status to the API? Looks like the "Initializing" will never returned to the API user anyway.
CHANGE DESCRIPTION
Problem:
EVEREST-107
Short explanation of the problem.
When it comes to create/update/delete backup storage and the associated secret, we have issues with data consistency and keeping secrets around if they're not needed.
Solution:
This PR aims to resolve the issues. The benefits include:
Create backup storage
Initializing
stateReady
Update backup storage
Delete backup storage
Open topics
Listed in the code with
TODO
comments.CHECKLIST
Jira
Tests