switch back to arkworks field arithmetic for 64-bit backend #101
Assignees
Comments
1 task
redshiftzero
pushed a commit
to penumbra-zone/penumbra
that referenced
this issue
Jul 10, 2024
## Describe your changes Updates the `decaf377`, `decaf377-rdsa`, and `poseidon377` dep versions ## Issue ticket number and link References #3676 and consumes changes in #3678. unblocked by penumbra-zone/decaf377#101 ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: --------- Co-authored-by: Lucas Meier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of penumbra-zone/penumbra#3526, we added
fiat-cryptoformally verified field arithmetic implementations todecaf377, moving away from using the Arkworks field arithmetic imlpementation. This unblocked development of Penumbra's ledger app, since the Arkworks field arithmetic allocated.However, @TalDerei did some very helpful benchmarking here and found that we have a significant performance regression.
This performance regression is blocking migrating downstream crates to the latest stable release (0.9.0, see #93). To move forward without introducing a performance regression we should switch back to Arkworks field arithmetic for the 64-bit backend only. Embedded environments like Ledger development will use the 32-bit backend which will continue to use the formally verified
fiat-cryptofield arithmetic.The text was updated successfully, but these errors were encountered: