diff --git a/PennMobile/src/main/java/com/pennapps/labs/pennmobile/AboutFragment.kt b/PennMobile/src/main/java/com/pennapps/labs/pennmobile/AboutFragment.kt index 22a34afd..bb2276bf 100644 --- a/PennMobile/src/main/java/com/pennapps/labs/pennmobile/AboutFragment.kt +++ b/PennMobile/src/main/java/com/pennapps/labs/pennmobile/AboutFragment.kt @@ -75,11 +75,6 @@ class AboutFragment : Fragment() { startActivity(i) } - view.feedback_btn?.setOnClickListener { - val link = Intent(Intent.ACTION_VIEW, Uri.parse("https://airtable.com/shr1oylDR3qzCpTXq")) - startActivity(link) - } - view.licenses_btn?.setOnClickListener { if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { val webView = LayoutInflater.from(mActivity).inflate(R.layout.dialog_licenses, null) as WebView diff --git a/PennMobile/src/main/java/com/pennapps/labs/pennmobile/more_fragments/PreferenceFragment.kt b/PennMobile/src/main/java/com/pennapps/labs/pennmobile/more_fragments/PreferenceFragment.kt index ea051d3d..bce557bf 100644 --- a/PennMobile/src/main/java/com/pennapps/labs/pennmobile/more_fragments/PreferenceFragment.kt +++ b/PennMobile/src/main/java/com/pennapps/labs/pennmobile/more_fragments/PreferenceFragment.kt @@ -126,6 +126,12 @@ class PreferenceFragment : PreferenceFragmentCompat() { return@setOnPreferenceClickListener true } + val feedbackPref: Preference? = findPreference("pref_feedback_link") + feedbackPref?.setOnPreferenceClickListener { + openLink(Feedback) + return@setOnPreferenceClickListener true + } + val pennHomepagePref: Preference? = findPreference("pref_penn_link") pennHomepagePref?.setOnPreferenceClickListener { openLink(PennHomepage) @@ -234,6 +240,7 @@ class PreferenceFragment : PreferenceFragmentCompat() { companion object { private const val PennLabs = "https://pennlabs.org" + private const val Feedback = "https://airtable.com/shr1oylDR3qzCpTXq" private const val PennHomepage = "https://www.upenn.edu" private const val CampusExpress = "https://prod.campusexpress.upenn.edu" private const val Canvas = "https://canvas.upenn.edu" diff --git a/PennMobile/src/main/res/layout/fragment_about.xml b/PennMobile/src/main/res/layout/fragment_about.xml index 11688872..57f197d9 100644 --- a/PennMobile/src/main/res/layout/fragment_about.xml +++ b/PennMobile/src/main/res/layout/fragment_about.xml @@ -122,19 +122,6 @@ app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@+id/about_mission_tv" /> -