Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between sample.py and sample_for_pdb.py #28

Open
VincentBt opened this issue Jun 13, 2023 · 1 comment
Open

Differences between sample.py and sample_for_pdb.py #28

VincentBt opened this issue Jun 13, 2023 · 1 comment

Comments

@VincentBt
Copy link

Hi, thank you for the great piece of work!

I was comparing sample.py and sample_for_pdb.py and I noticed that only the second file had queue_weight. Is there any reason for that? I guess this helps generating more diverse molecules.

I also noticed another difference: the possibility in sample.py (but not in sample_for_pdb.py) to use LigandBFSMask masking instead of LigandMaskAll: what is the use of it?

Thank you very much!

@pengxingang
Copy link
Owner

Hi, thanks for your interest.

The queue_weight parameter was introduced to address situations where a single sample has an excessive number of descendant samples. This can lead to decreased diversity in the generated molecules. Moreover, we have noticed that it can sometimes result in the generation of molecules with multiple rings, resembling polycyclic aromatic hydrocarbons, which is not desired.

Regarding the LigandBFSMask and LigandMaskAll options for sampling, if the masking ratio is set to 100%, there is no practical difference between the two. You can choose either option without affecting the outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants