Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT/BUG: single _AiocaShim.get('pv') should return a CommunicationError in the same way as list version #74

Open
tangkong opened this issue Aug 9, 2024 · 0 comments
Assignees
Labels
Backend Backend data source related issues bug Something isn't working

Comments

@tangkong
Copy link
Contributor

tangkong commented Aug 9, 2024

Current Behavior

Currently the single-pv version raises the communication error, while the list version returns a list of such errors.

Expected Behavior

The two should act similarly

Context / environment

poking around #73 , this is something I saw in the past but never ironed out

Steps to Reproduce (for bugs)

  1. from superscore.control_layers import ControlLayer; cl = ControlLayer()
  2. res_single = cl.get('nonsense:non:working:pv') (should raise)
  3. res_list = cl.get(['nonsense', 'nonsense2']) (should return list)
  4. Compare res_single, res_list

Suggested Solution

Catch the exception in the single version and return it?

@tangkong tangkong added bug Something isn't working Backend Backend data source related issues labels Aug 20, 2024
@shilorigins shilorigins self-assigned this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Backend data source related issues bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants