Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate DataclassBridge caching and deallocation performance #52

Open
tangkong opened this issue Jul 1, 2024 · 1 comment
Open

Comments

@tangkong
Copy link
Contributor

tangkong commented Jul 1, 2024

Current Behavior

The QDataclassBridge structure was vendored from atef nearly verbatim, along with some comments suggesting we revisit the dataclass caching mechanisms

Expected Behavior

Framework works as intended, with no noticeable issues

Context / environment

Noticed in #38

Steps to Reproduce (for bugs)

N/A

Suggested Solution

Look for issues in caching, make sure garbage collection is occurring as planned, etc

@tangkong
Copy link
Contributor Author

To be clear, we (ECS) haven't run into any problems with this in our time using the pattern. We created this issue preemptively, but we've not run into a bug yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant