Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Build Entry comparison page (Snapshots only?) #48

Open
Tracked by #19
tangkong opened this issue Jul 1, 2024 · 5 comments
Open
Tracked by #19

GUI: Build Entry comparison page (Snapshots only?) #48

tangkong opened this issue Jul 1, 2024 · 5 comments
Assignees
Labels
GUI Graphical User Interface related issue

Comments

@tangkong
Copy link
Contributor

tangkong commented Jul 1, 2024

No description provided.

@tangkong tangkong changed the title Build Entry comparison page (Snapshots only?) GUI: Build Entry comparison page (Snapshots only?) Jul 1, 2024
@shilorigins shilorigins added the GUI Graphical User Interface related issue label Jul 1, 2024
@tangkong tangkong added this to the Minimum Viable Product milestone Jul 2, 2024
@tangkong
Copy link
Contributor Author

This looks like it relies on #9 , @shilorigins did you already start work on the client-level comparison function? If not I can take a crack at it

@shilorigins
Copy link
Collaborator

I haven't. But this issue seems like it overlaps with the restore page functionality of comparing snapshots. That one is focused on PV values, is this one focused on metadata or something other than the contained PVs?

@tangkong
Copy link
Contributor Author

At the very least, I think that this comparison should happen at the client level, rather than in the UI. Ideally the UI calls this client function, and picks the data that it cares about.

If we sequester this functionality inside the UI, we won't be able to access it from other apps that only use the client.

@shilorigins
Copy link
Collaborator

Sure, and I can write the snapshot portion of the client method since I'll use it for the restore page. But I was also thinking about how this comparison page will handle snapshots, because of that overlap between the pages.

@tangkong tangkong self-assigned this Nov 11, 2024
@tangkong
Copy link
Contributor Author

I want to take a look at this for comparing arbitrary Entry's, I think a complete treatment of this probably looks pretty different from the existing snapshot restore page

@tangkong tangkong mentioned this issue Dec 4, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Graphical User Interface related issue
Projects
None yet
Development

No branches or pull requests

2 participants