Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: expanding tree view entry shows data with no titles or descriptions #113

Open
shilorigins opened this issue Dec 5, 2024 · 1 comment · May be fixed by #114
Open

BUG: expanding tree view entry shows data with no titles or descriptions #113

shilorigins opened this issue Dec 5, 2024 · 1 comment · May be fixed by #114
Assignees
Labels
bug Something isn't working GUI Graphical User Interface related issue

Comments

@shilorigins
Copy link
Collaborator

Current Behavior

  1. Launch superscore (superscore demo)
  2. Double-click snapshot entry in tree view to open detailed page
  3. Click the same entry's arrow in the tree view to expand the entry
  4. Observe missing data in tree view sub-entries
Screen.Recording.2024-12-05.at.14.45.27.mov

Expected Behavior

Data should populate correctly in the tree view regardless of which pages have been opened or how.

Context / environment

@shilorigins shilorigins added bug Something isn't working GUI Graphical User Interface related issue labels Dec 5, 2024
@tangkong
Copy link
Contributor

tangkong commented Dec 6, 2024

I think I understand how this is happening.

We start with an unfilled tree item. The dataclass has UUIDs for children, and the EntryItem (tree item) has children holding those UUIDs.

Opening the detailed page takes the aforementioned dataclass and sets it as the root of a new RootTree, which does initial filling (when initializing the sub-page tree). This fills the dataclass and makes valid children for the detailed view page.

However, this dataclass is shared between the sub-page and parent page tree, so the UUIDs in the parent tree are also filled without updating the tree items. The current canFetchMore implementation doesn’t trigger a fill and subsequently doesn’t replace the EntryItem children

I think fixing this might be as simple as adjusting the canFetchMore check to also look through EntryItem children and re-generate regenerate them if needed

@tangkong tangkong self-assigned this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI Graphical User Interface related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants