Skip to content

Commit

Permalink
Merge pull request #1312 from ZLLentz/fix_mmc100_sig
Browse files Browse the repository at this point in the history
FIX: override velocity_base in MMC100, it doesn't have one
  • Loading branch information
ZLLentz authored Dec 11, 2024
2 parents f7dc881 + b4163e0 commit 6ee28b7
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 0 deletions.
34 changes: 34 additions & 0 deletions docs/source/upcoming_release_notes/1312-fix_mmc100_sig.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
1312 fix_mmc100_sig
###################

API Breaks
----------
- N/A

Library Features
----------------
- N/A

Device Features
---------------
- N/A

New Devices
-----------
- N/A

Bugfixes
--------
- Replace the ``velocity_base`` (``.VBAS``) signal in the `MMC100` class
with a base `Signal` to avoid a PV disconnected error
that was preventing moves.
The `MMC100` record does not have this field.
With this fix, `MMC100` devices can move again.

Maintenance
-----------
- N/A

Contributors
------------
- zllentz
2 changes: 2 additions & 0 deletions pcdsdevices/epics_motor.py
Original file line number Diff line number Diff line change
Expand Up @@ -1235,6 +1235,8 @@ class MMC100(PCDSMotorBase):
home_forward = Cpt(EpicsSignal, '.MLP', kind='omitted')
home_reverse = Cpt(EpicsSignal, '.MLN', kind='omitted')

velocity_base = Cpt(Signal, kind='omitted')


class BeckhoffAxisPLC(Device):
"""
Expand Down

0 comments on commit 6ee28b7

Please sign in to comment.