TST: small change to csvs to test xml generation #54
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that specifying the ref in a workflow works for PRs originating from forks. I also think we have to merge this to see if I'm right |
| @@ -23,7 +23,6 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 0 | |||
| ref: ${{ github.head_ref }} | |||
There was a problem hiding this comment.
SInce this job triggers on pull_request_target and not pull_request, the default checkout would be the branch we are merging into. So if we are trying to merge into the master branch, we would just compare it with itself and post an empty diff.
I think what's happening is that it's trying to checkout the source branch from the target repo (I hope I'm using the right terminology) which doesn't exist. Maybe this would work?
ref: "${{ github.event.pull_request.head.ref }}"
repository: "${{ github.event.pull_request.head.repo.full_name }}"
where we explicitly define where the branch is coming from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR is working and (presumably) checking out the repo with an ssh key. This aims to fully flex the xml-generation