Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More TwinCAT pragma linting #71

Open
ZLLentz opened this issue Mar 31, 2022 · 1 comment
Open

More TwinCAT pragma linting #71

ZLLentz opened this issue Mar 31, 2022 · 1 comment

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Mar 31, 2022

We've seen a couple issues where people make typos in their TcLinkTo pragmas that silently break their projects.

Most commonly:

  • forgetting to close the quote block
  • forgetting a semicolon to separate different links to one DUT
  • putting a hanging semicolon at the end of the block

And these all break things. We could probably also catch these in the CI, where we're mainly focused on the pytmc pragma linting right now.

@ZLLentz ZLLentz changed the title More pragma linting More TwinCAT pragma linting Mar 31, 2022
@klauer
Copy link
Contributor

klauer commented Mar 31, 2022

For easy reference:
https://github.com/pcdshub/pytmc/blob/master/pytmc/bin/pragmalint.py

Also semi-related in that we want to warn/error on such failures:
pcdshub/pytmc#277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants