Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in struct name for normally open valves #97

Open
ZLLentz opened this issue Mar 31, 2022 · 2 comments
Open

Typo in struct name for normally open valves #97

ZLLentz opened this issue Mar 31, 2022 · 2 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Mar 31, 2022

The normally open valve class is ST_VCCNO
Surely it is meant to be ST_VVCNO?

I'm not sure this matters at all.
https://github.com/pcdshub/lcls-twincat-vacuum/blob/master/L2SIVacuum/DUTs/Valves/ST_VCC_NO.TcDUT
@ghalym
Copy link
Collaborator

ghalym commented Mar 31, 2022

It was named VCC before the CCC name change to VVC.
We need to Fix it in new releases..
Thanks.

@ZLLentz
Copy link
Member Author

ZLLentz commented Apr 1, 2022

Gotcha! No rush or anything, I just saw it while trying to write docs for the python valve classes and it confused me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZLLentz @ghalym