Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For FB_VGC_2S.TcPOU Please set the DP interlock to be true by default so the GUI screen shows the correct logic #70

Open
slacAdpai opened this issue Dec 3, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@slacAdpai
Copy link
Contributor

FB_VGC_2S.TcPOU should set the differential pressure to be true by default because it is not even checked in the interlock:

(* As long as the differential pressure is less than 30mbar, the valve is allowed to open )
IF rDiffPress <= rDiffPressAllowed AND i_stUSG.xPRESS_OK AND i_stDSG.xPRESS_OK THEN
iq_stValve.xDP_OK := TRUE;
ELSE
iq_stValve.xDP_OK := FALSE;
(
If the differential pressure is exceeded, even when the valve is open,
the state is unexpected and triggers a fault, because it suggests that something
is wrong with the valve, or gauges or mapping or there is a major leak on one side.*)
iq_stValve.eVGC_State := ERR_DiffPress;
iq_stValve.xERR_DifPres := TRUE;
END_IF

@slacAdpai slacAdpai changed the title Please set the DP interlock to be true by default so the GUI screen shows the correct logic For FB_VGC_2S.TcPOU Please set the DP interlock to be true by default so the GUI screen shows the correct logic Dec 3, 2020
@slacAdpai slacAdpai added the bug Something isn't working label Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants