Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change valve, gpi, gcc, pip setpoint hysteresis to a percentage of the protection/atvac setpoint #41

Open
slacAdpai opened this issue Jun 18, 2020 · 2 comments
Assignees

Comments

@slacAdpai
Copy link
Contributor

slacAdpai commented Jun 18, 2020

Currently the hysteresis setpoint and protection/atvac setpoints can vary greatly. The VGC setpoint hysteresis is a little smarter and does not allow the hysterisis setpoint be above the atvac setpoint/protection. A more intuitive design would be to set the hysteresis to be a percentage of the protection/atvac setpoint.

Bill and I were getting confused when changing the setpoint hysteresis did not change it because the protection/atvac setpoint was below the hysteresis.

@ghalym
Copy link
Collaborator

ghalym commented Jun 18, 2020

Good point. Will work on that.

@slacAdpai
Copy link
Contributor Author

A good starting point is VGC. You already have half of it done there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants