Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where holding current couldn't be disabled from the button once enabled. #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NSLentz
Copy link
Contributor

@NSLentz NSLentz commented Dec 7, 2024

Description

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@NSLentz NSLentz requested a review from rcjwoods December 7, 2024 18:16
@NSLentz
Copy link
Contributor Author

NSLentz commented Dec 7, 2024

@rcjwoods I realized I forgot to include turning holding current back off. I just put it in using an ELSE statement that switches back to DURING_MOTION when holding current is not enabled.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants