adding gas jet encoder Y and Z #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSLentz
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LAMP adds three encoders into gas jet X,Y,Z.
Y and X have issues, not working.
Scientists remove the manipulators already, waiting for new manipulators coming next Jan.
I can't trouble shoot this anymore.
But I need to scan a new terminal to prepare commission next Jan.
I want to merge this code first and after scanning new terminal, can work on the brand new manipulators on Jan.
gas jet axes link to new encoders
Motivation and Context
Wants to add encoders into three axes
https://jira.slac.stanford.edu/browse/ECS-6779
How Has This Been Tested?
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)