Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fix Comment in wad_exp #212

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

zhouxianyuan
Copy link
Contributor

@zhouxianyuan zhouxianyuan commented Mar 8, 2024

🕓 Changelog

Revise the comment in wad_exp from < 0.5 to < 1 to ensure consistency with the implementation.

🐶 Cute Animal Picture

image

@pcaversaccio pcaversaccio self-requested a review March 8, 2024 08:47
@pcaversaccio
Copy link
Owner

pcaversaccio commented Mar 8, 2024

Ok, I just verified that exp(-41.446531673892822312) yields:

0.000000000000000001_00000000000000000032384618431855573687226497086675755641671093370608029764125820546168033941594517613715929615438952360683386034935582334897098932984892

and exp(-41.446531673892822313) yields:

0.000000000000000000_99999999999999999932384618431855573704841878654820181953970238833193394298170539313588619717615853339733266852465617238851717356196353027188571558619488

and the old comment was related to the expression exp(-42.139678854452767551) (see here), yielding:

0.000000000000000000_50000000000000003537053915288836740352270343084797256987197084168752771444839883138733470003894871082191707084689128857631928612944262161920887697007978

Thanks for spotting this @zhouxianyuan!

@pcaversaccio pcaversaccio changed the title ♻️ fix comment in function wad_exp() 📖 Fix Comment in wad_exp Mar 8, 2024
@pcaversaccio pcaversaccio self-assigned this Mar 8, 2024
@pcaversaccio pcaversaccio added the documentation 📖 Improvements or additions to documentation label Mar 8, 2024
@pcaversaccio pcaversaccio enabled auto-merge (squash) March 8, 2024 11:49
@pcaversaccio pcaversaccio added this to the 0.1.0 milestone Mar 8, 2024
@pcaversaccio pcaversaccio merged commit 46c5f83 into pcaversaccio:main Mar 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants