Form plugin sends email before data got validated and written

[cbratschi]

Describe the Bug

The confirmation email is sent in the beforeChange hook:

payload/packages/plugin-form-builder/src/collections/FormSubmissions/index.ts

Line 110 in afcc970

(data) => sendEmail(data, formConfig),

In case validation fails no data got stored.

Solution: use afterChange hook or the afterCommit hook I proposed in another ticket.

Link to the code that reproduces this issue

https://github.com/cbratschi/payload

Reproduction Steps

See above.

Which area(s) are affected? (Select all that apply)

plugin: form-builder

Environment Info

Binaries:
  Node: 22.12.0
  npm: 10.9.0
  Yarn: 1.22.22
  pnpm: N/A
Relevant Packages:
  payload: 3.13.0
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 24.1.0: Thu Oct 10 21:05:23 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6031
  Available memory (MB): 65536
  Available CPU cores: 16

[akhrarovsaid]

Hey @cbratschi,

So, the collection beforeChange hook is supposed to run only after validation succeeds in a manner where you can be confident that the data is valid and will be saved to the document. In other words, "before changes" are saved. The docs even point out that it will run within create and update operations.

Moving this to an afterChange should still work, although I don't think it's necessary here personally.

[cbratschi]

@akhrarovsaid I received the email, then validation failed and no document was saved.