Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow recipeint to contribute fee if receiver sets their own minfeerate #41

Closed
DanGould opened this issue Mar 2, 2023 · 2 comments
Closed
Labels
api receive receiving payjoin
Milestone

Comments

@DanGould
Copy link
Contributor

DanGould commented Mar 2, 2023

Now even if a minfeerate is specified by the client the receiver never contributes fees

This is especially critical if the sender's maxadditionalfeecontribution is less than the amount to maintain feerate, either if they don't have enough sats (unlikely) or the receiver wants to add more inputs and outputs to batch transactions

@DanGould DanGould added the receive receiving payjoin label May 27, 2023
@DanGould DanGould added the api label Jul 7, 2023
@DanGould DanGould added this to the 1.0 milestone Jul 31, 2023
@jbesraa
Copy link
Contributor

jbesraa commented Mar 12, 2024

Is this still needed? happy to pick it up if so.

@spacebear21
Copy link
Collaborator

Closed by #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api receive receiving payjoin
Projects
Status: Done
Development

No branches or pull requests

3 participants