Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 0.21 payjoin_ffi integrations #2

Open
DanGould opened this issue Nov 12, 2024 · 0 comments · Fixed by #1
Open

Test 0.21 payjoin_ffi integrations #2

DanGould opened this issue Nov 12, 2024 · 0 comments · Fixed by #1

Comments

@DanGould
Copy link

DanGould commented Nov 12, 2024

v1-to-v1 is no longer the most relevant payjoin-ffi since it doesn't support payjoin-ffi doesn't ship a pure v1 receiver. The following are the relevant code paths to test:

  • v2-to-v2
  • v1-to-v2
  • v2-to-v1 (with rust-payjoin::v1 feature, manual extract_v1 would ignore handling the v1 receiver version error)

Testing each of these should ensure that v1-to-v1 actually works, but will never be hit with our shipped state machines.

@DanGould DanGould assigned DanGould and unassigned DanGould Nov 12, 2024
@DanGould DanGould reopened this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant