-
Notifications
You must be signed in to change notification settings - Fork 11
Comparing changes
Open a pull request
base repository: Kixunil/bip21
base: master
head repository: payjoin/bitcoin_uri
compare: master
- 19 commits
- 7 files changed
- 3 contributors
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1b19687 - Browse repository at this point
Copy the full SHA 1b19687View commit details
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c38295c - Browse repository at this point
Copy the full SHA c38295cView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb32638 - Browse repository at this point
Copy the full SHA eb32638View commit details
Commits on Dec 2, 2024
-
Specify escaped characters more conservatively
'#'' is not in the set qchar indirectly defined in BIP 21, and therefore should be escaped. [BIP 21](https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki#abnf-grammar): > labelparam = "label=" *qchar > messageparam = "message=" *qchar > otherparam = qchar *qchar [ "=" *qchar ] ... > Here, "qchar" corresponds to valid characters of an RFC 3986 URI query > component, excluding the "=" and "&" characters, which this BIP takes > as separators. [RFC 3986 § 3.4](https://www.rfc-editor.org/rfc/rfc3986#section-3.4): > The query component is indicated by the first question mark ("?") > character and terminated by a number sign ("#") character or by the > end of the URI. [RFC 3986 Appendix A](https://www.rfc-editor.org/rfc/rfc3986#appendix-A): > pchar = unreserved / pct-encoded / sub-delims / ":" / "@" > query = *( pchar / "/" / "?" ) ... > pct-encoded = "%" HEXDIG HEXDIG > unreserved = ALPHA / DIGIT / "-" / "." / "_" / "~" ... > sub-delims = "!" / "$" / "&" / "'" / "(" / ")" > / "*" / "+" / "," / ";" / "="
Configuration menu - View commit details
-
Copy full SHA for 0585806 - Browse repository at this point
Copy the full SHA 0585806View commit details -
Ignore RFC 3986 fragments in BIP 21 URIs
Although behavior for when encountering RFC 3986 fragments in BIP 21 URIs is not specified, according to RFC 3986 it is unambiguously not query data and therefore should be excluded from BIP 21 query parameters.
Configuration menu - View commit details
-
Copy full SHA for 646de25 - Browse repository at this point
Copy the full SHA 646de25View commit details -
Merge pull request #3 from nothingmuch/escaping-rules
Fix escaping of '#' in parameter values and handling of unescaped '#' in uri
Configuration menu - View commit details
-
Copy full SHA for a02bdb5 - Browse repository at this point
Copy the full SHA a02bdb5View commit details -
Merge pull request #4 from lsunsi/master
fix: unicode on exactly index 7 should not panic
Configuration menu - View commit details
-
Copy full SHA for 76244b1 - Browse repository at this point
Copy the full SHA 76244b1View commit details -
Replace is_some_and with map_or for MSRV
is_some_and is stable only in Rust 1.70.0 and greater. map_or(false, |s| s.eq_ignore_ascii_case(SCHEME)): - This method is used to handle the Option returned by get(). - If get() returns None (i.e., the string is too short), map_or() returns false. - If get() returns Some(s), it applies the closure |s| s.eq_ignore_ascii_case(SCHEME). - This closure checks if the substring s is equal to SCHEME, ignoring ASCII case differences. - If they are equal, it returns true; otherwise, it returns false.
Configuration menu - View commit details
-
Copy full SHA for 59f464c - Browse repository at this point
Copy the full SHA 59f464cView commit details -
Merge pull request #5 from DanGould/fix-scheme-fix
Replace is_some_and with map_or for MSRV
Configuration menu - View commit details
-
Copy full SHA for e5a2c87 - Browse repository at this point
Copy the full SHA e5a2c87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71a8ae2 - Browse repository at this point
Copy the full SHA 71a8ae2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a827cb3 - Browse repository at this point
Copy the full SHA a827cb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9242659 - Browse repository at this point
Copy the full SHA 9242659View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63062b1 - Browse repository at this point
Copy the full SHA 63062b1View commit details -
Silence unused UriErerorInner dead code
The error is only passed up via `source` when `std::error::Error` is available. When the feature is off, it's dead code.
Configuration menu - View commit details
-
Copy full SHA for 8cc5ff7 - Browse repository at this point
Copy the full SHA 8cc5ff7View commit details -
Allow dead code for ParamBytes inner
The code isn't actually dead, and is used in the bytes() function, but the compiler's dead code analysis doesn't fully track usage through feature flags and doesn't count if the pattern isn't considered a read of the field.
Configuration menu - View commit details
-
Copy full SHA for 2675825 - Browse repository at this point
Copy the full SHA 2675825View commit details -
Merge pull request #1 from DanGould/pin-1-56
Get CI into production-ready shape
Configuration menu - View commit details
-
Copy full SHA for 76db0d1 - Browse repository at this point
Copy the full SHA 76db0d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for de4162b - Browse repository at this point
Copy the full SHA de4162bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3958a2b - Browse repository at this point
Copy the full SHA 3958a2bView commit details -
Merge pull request #2 from DanGould/rename-bitcoin_uri
Rename crate bitcoin_uri
Configuration menu - View commit details
-
Copy full SHA for 9362fab - Browse repository at this point
Copy the full SHA 9362fabView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master