Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Kixunil/bip21
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: payjoin/bitcoin_uri
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 19 commits
  • 7 files changed
  • 3 contributors

Commits on Sep 25, 2024

  1. Copy the full SHA
    1b19687 View commit details

Commits on Oct 21, 2024

  1. Copy the full SHA
    c38295c View commit details
  2. Copy the full SHA
    eb32638 View commit details

Commits on Dec 2, 2024

  1. Specify escaped characters more conservatively

    '#'' is not in the set qchar indirectly defined in BIP 21, and therefore
    should be escaped.
    
    [BIP 21](https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki#abnf-grammar):
    
    >     labelparam     = "label=" *qchar
    >     messageparam   = "message=" *qchar
    >     otherparam     = qchar *qchar [ "=" *qchar ]
    ...
    > Here, "qchar" corresponds to valid characters of an RFC 3986 URI query
    > component, excluding the "=" and "&" characters, which this BIP takes
    > as separators.
    
    [RFC 3986 § 3.4](https://www.rfc-editor.org/rfc/rfc3986#section-3.4):
    
    > The query component is indicated by the first question mark ("?")
    > character and terminated by a number sign ("#") character or by the
    > end of the URI.
    
    [RFC 3986 Appendix A](https://www.rfc-editor.org/rfc/rfc3986#appendix-A):
    
    >     pchar         = unreserved / pct-encoded / sub-delims / ":" / "@"
    >     query         = *( pchar / "/" / "?" )
    ...
    >     pct-encoded   = "%" HEXDIG HEXDIG
    >     unreserved    = ALPHA / DIGIT / "-" / "." / "_" / "~"
    ...
    >     sub-delims    = "!" / "$" / "&" / "'" / "(" / ")"
    >                   / "*" / "+" / "," / ";" / "="
    nothingmuch committed Dec 2, 2024
    Copy the full SHA
    0585806 View commit details
  2. Ignore RFC 3986 fragments in BIP 21 URIs

    Although behavior for when encountering RFC 3986 fragments in BIP 21
    URIs is not specified, according to RFC 3986 it is unambiguously not
    query data and therefore should be excluded from BIP 21 query
    parameters.
    nothingmuch committed Dec 2, 2024
    Copy the full SHA
    646de25 View commit details
  3. Merge pull request #3 from nothingmuch/escaping-rules

    Fix escaping of '#' in parameter values and handling of unescaped '#' in uri
    DanGould authored Dec 2, 2024
    Copy the full SHA
    a02bdb5 View commit details
  4. Merge pull request #4 from lsunsi/master

    fix: unicode on exactly index 7 should not panic
    DanGould authored Dec 2, 2024
    Copy the full SHA
    76244b1 View commit details
  5. Replace is_some_and with map_or for MSRV

    is_some_and is stable only in Rust 1.70.0 and greater.
    
    map_or(false, |s| s.eq_ignore_ascii_case(SCHEME)):
      - This method is used to handle the Option returned by get().
      - If get() returns None (i.e., the string is too short), map_or()
        returns false.
      - If get() returns Some(s), it applies the closure
        |s| s.eq_ignore_ascii_case(SCHEME).
         - This closure checks if the substring s is equal to SCHEME,
           ignoring ASCII case differences.
         - If they are equal, it returns true; otherwise, it returns
           false.
    DanGould committed Dec 2, 2024
    Copy the full SHA
    59f464c View commit details
  6. Merge pull request #5 from DanGould/fix-scheme-fix

    Replace is_some_and with map_or for MSRV
    DanGould authored Dec 2, 2024
    Copy the full SHA
    e5a2c87 View commit details
  7. Copy the full SHA
    71a8ae2 View commit details
  8. Copy the full SHA
    a827cb3 View commit details
  9. Use rust MSRV 1.63.0

    DanGould committed Dec 2, 2024
    Copy the full SHA
    9242659 View commit details
  10. Act on: pull-request

    DanGould committed Dec 2, 2024
    Copy the full SHA
    63062b1 View commit details
  11. Silence unused UriErerorInner dead code

    The error is only passed up via `source` when `std::error::Error` is
    available. When the feature is off, it's dead code.
    DanGould committed Dec 2, 2024
    Copy the full SHA
    8cc5ff7 View commit details
  12. Allow dead code for ParamBytes inner

    The code isn't actually dead, and is used in the bytes() function, but the
    compiler's dead code analysis doesn't fully track usage through feature flags
    and doesn't count if the pattern isn't considered a read of the field.
    DanGould committed Dec 2, 2024
    Copy the full SHA
    2675825 View commit details
  13. Merge pull request #1 from DanGould/pin-1-56

    Get CI into production-ready shape
    DanGould authored Dec 2, 2024
    Copy the full SHA
    76db0d1 View commit details
  14. Rename crate bitcoin_uri

    DanGould committed Dec 2, 2024
    Copy the full SHA
    de4162b View commit details
  15. Add CHANGELOG.md

    DanGould committed Dec 2, 2024
    Copy the full SHA
    3958a2b View commit details
  16. Merge pull request #2 from DanGould/rename-bitcoin_uri

    Rename crate bitcoin_uri
    DanGould authored Dec 2, 2024
    Copy the full SHA
    9362fab View commit details
Loading