bugfix: Split CDI bean deployment when multiple WARs exist in an EAR #7032
Conversation
|
@Pandrex247 Do you think you can run the TCK against this PR? Thank you! |
lprimak
changed the title
|
@lprimak I ran it through the CDI and EJB TCKs and all seems green 👍 |
|
Thanks, Fantastic! |
appserver/web/weld-integration/src/main/java/org/glassfish/weld/WeldDeployer.java
Outdated
Show resolved
Hide resolved
lprimak
force-pushed
the
cdi-ear-exception
branch
from
1c8a517
to
93071cf
Compare
|
I have found a few issues that I found with "real" applications. |
|
|
lprimak
force-pushed
the
cdi-ear-exception
branch
2 times, most recently
from
89ef769
to
4a79348
Compare
|
Im getting close. "Real" application runs. |
lprimak
force-pushed
the
cdi-ear-exception
branch
from
61c4079
to
2471951
Compare
|
Ready to go. Will do #6405 in a separate PR |
|
Now I gotta fix the conflict :) |
|
Once the tests passes I am going to squash the commits and un-draft the PR again |
…I-enabled library JARs - correctly copy BDA sets for each war in EAR - Make WAR's CDI beans available in EAR-libs - read web-fragment.xml from EAR-libs - processing ear-lib manifest - de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList - made some structures final (cleanup) - fixed ear and concurrent classloader leaks
lprimak
force-pushed
the
cdi-ear-exception
branch
from
766eb3e
to
d2fbb5a
Compare
|
Ready to go again |
| <configuration> | ||
| <parameter> | ||
| <excludes> | ||
| <exclude>org.glassfish.web.loader.CachingReflectionUtil</exclude> |
There was a problem hiding this comment.
I believe this will break semantic versioning, this will require reworking your changes.
There was a problem hiding this comment.
This is an internal class. It was moved into a different module. Nothing should be affected.
Description
Bugfix. BeanManager isn't properly constructed when multiple CDI WARs exist in an EAR.
Also allows EAR-libraries to be scanned for CDI annotations
fixes #7031
also fixes #7078
Appears specifically when multiple WARs use OmniFaces
Testing
Tested with the failing reproducer
** Needs TCK run