Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only add body if verb is not head #870

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

DyfanJones
Copy link
Member

Ensure head has empty body. This ensure head isn't turn off by post.

curl options:

When setting CURLOPT_POST to 1, libcurl automatically sets CURLOPT_NOBODY and CURLOPT_HTTPGET to 0

A long parameter set to 1 tells libcurl to not include the body-part in the output when doing what would otherwise be a download. For HTTP(S), this makes libcurl do a HEAD request

Fixes: #868

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.20%. Comparing base (91ac751) to head (981c3a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
+ Coverage   83.14%   83.20%   +0.06%     
==========================================
  Files         219      146      -73     
  Lines       16106    10740    -5366     
==========================================
- Hits        13391     8936    -4455     
+ Misses       2715     1804     -911     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DyfanJones DyfanJones added the bug 🐞 Something isn't working label Jan 3, 2025
@DyfanJones DyfanJones merged commit d8ce162 into paws-r:main Jan 3, 2025
7 checks passed
@wlandau wlandau mentioned this pull request Jan 3, 2025
@DyfanJones DyfanJones added this to the Paws 0.8.0 cran release milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 HEAD request 403 error
1 participant