Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currentSlide Bug #280

Open
cameronkuo opened this issue Nov 10, 2020 · 3 comments
Open

currentSlide Bug #280

cameronkuo opened this issue Nov 10, 2020 · 3 comments

Comments

@cameronkuo
Copy link

Hi @pawelgrzybek,

Siema is such a great plugin, but I found a problem:

When the "perPage" is greater than 1, the currentSlide will get wrong index.

Please check it.

Thanks.

@galingong
Copy link

I can confirm this, just ran into the bug myself.

@cameronkuo
Copy link
Author

@galingong @pawelgrzybek Was this solved?

@Dan-dilion
Copy link

Dan-dilion commented Dec 1, 2022

I'm not sure if this has been resolved or not (we are using an out of date version of Siema) but if you run in to this problem it seems to occasionally subtract the number of slides from the currentSlide so you can get the correct currentSlide with a simple turnery like this:

(mySiema.currentSlide < 0)
  ? (mySiema.innerElements.length + mySiema.currentSlide)
  : mySiema.currentSlide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants