-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iFrame slide content reloads on resize #205
Comments
Hi. No, PR is not needed. I will address this issue in a next version. Thanks for reporting an issue. Have a great day 👋 |
Hi. I think I have the same issue. When embedding YouTube videos, clicking on the full-screen icon triggers a reload of the iframe, which (of course) closes the full-screen of the previous iframe immediately. Anything I can do to fix this as soon as possible? |
Hi @pawelgrzybek, We don't want to switch to another plugin, but the current fix is necessarily required in nearest time for avoiding our transition. Thanks in advance! |
Does anyone know a workaround for this issue? |
I did something like this to work around the issue:
Sure there's improvements to be made but seems to do the trick as far as I can see. |
Example here: https://codepen.io/Bobsworth/pen/EexJxP
When the page is resized, the iFrame "reloads".
This is undesirable as it will reset the iframe and flash.
In my production usage where I discovered this I have a Siema carousel in the iframe, which itself is slide 2 of a Siema carousel! So if the page is resized the inner carousel will reset to slide 1 when the iframe reloads.
This is from the resizehandler calling buildSliderFrame which recreates the inner elements, creating a new iframe element which loads again, appearing to be refreshing.
I fixed this by not recreating the docFragment on resize (in a new reBuildSliderFrame method).
I can create a pull request later.
The text was updated successfully, but these errors were encountered: