Skip to content
This repository has been archived by the owner on Sep 18, 2019. It is now read-only.

Google Font Control doesn't pass theme check #11

Open
design311 opened this issue Jul 23, 2014 · 2 comments
Open

Google Font Control doesn't pass theme check #11

design311 opened this issue Jul 23, 2014 · 2 comments

Comments

@design311
Copy link

File operations should use the WP_Filesystem methods instead of direct PHP filesystem calls.

http://codex.wordpress.org/Filesystem_API

WordPress stackexchange: http://wordpress.stackexchange.com/questions/155480/wp-filesystem-in-custom-customize-control

@ryanhellyer
Copy link

This should use transients instead of defaulting to the file system to cache this data.

It also uses raw API keys in the code, which is not viable for themes submitted to the repository since Google doesn't not approve of sharing the API keys, and there are usage limits on each key. Theme users could either enter their own API key, or (better) the developer could cache the font options on their own server and access them via that instead (hence bypassing the need to share Google API keys).

@ryanhellyer
Copy link

I created a pull request with solutions for these issues ... #21

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants