Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brogue taking a long time to generate #54

Open
airstruck opened this issue Aug 3, 2017 · 1 comment
Open

Brogue taking a long time to generate #54

airstruck opened this issue Aug 3, 2017 · 1 comment

Comments

@airstruck
Copy link

Noticed one of the tests hanging and discovered brogue dungeon generation was taking much longer than everything else combined.

Apparently these dungeons try to place rooms 1000 times, and don't have any "stop conditions" other than max room count, which defaults to 99 (never hit on a normal sized map).

Would recommend changing room count to a more sensible default, or adding some other stop conditions, like percent dug, or doing something like detecting 100 failed room placements in a row (resetting counter on successful placement). As it is, much of the time spent on brogue dungeon generation appears to happen after the dungeon is full.

@airstruck
Copy link
Author

Would it be possible to merge Brogue into Digger somehow? If Digger were given an option to generate a Cellular map, an option to "generate loops," and a BrogueRoom feature, how much different from Brogue would it be?

One thing I'm not sure about is the "blob" stuff, is the point of that to mark diggable walls on the cellular map?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant